Skip to content

Commit

Permalink
Fix logs stuck in pending symbolocated state
Browse files Browse the repository at this point in the history
Summary:
This diff fixes an issue where symbolicated logs were getting stuck in a "pending" state if the timeout occurred before symbolication finished.

Changelog: [Internal]

Reviewed By: sahrens

Differential Revision: D18894154

fbshipit-source-id: ed225962468f67aef40e430aa798f8d426d31027
  • Loading branch information
rickhanlonii authored and facebook-github-bot committed Dec 10, 2019
1 parent bbfd64e commit 3714bfe
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Libraries/LogBox/Data/LogBoxData.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ function appendNewLog(newLog) {
if (addPendingLog && status !== 'PENDING') {
addPendingLog();
clearTimeout(optimisticTimeout);
} else if (status !== 'PENDING') {
// The log has already been added but we need to trigger a render.
handleUpdate();
}
});
} else {
Expand Down

0 comments on commit 3714bfe

Please sign in to comment.