Set textBreakStrategy default to be HighQuality

Summary:
Android TextView's default for breakStrategy is BREAK_STRATEGY_HIGH_QUALITY (https://developer.android.com/reference/android/widget/TextView#setBreakStrategy(int))

RN docs also states that highQuality is default.

However, on Fabric, the default is 'simple'. This diff fixes the default to be 'highQuality'

Changelog:
[Android][Fixed] - Set textBreakStrategy default to be 'highQuality'

Reviewed By: JoshuaGross

Differential Revision: D30597085

fbshipit-source-id: 3bd7531afdaf980b342cc461dd449c3d3df12cb0

ReactCommon/react/renderer/attributedstring/ParagraphAttributes.cpp

@@ -51,8 +51,7 @@ SharedDebugStringConvertibleList ParagraphAttributes::getDebugProps() const {
       debugStringConvertibleItem("maximumFontSize", maximumFontSize),
       debugStringConvertibleItem("includeFontPadding", includeFontPadding),
       debugStringConvertibleItem(
-          "android_hyphenationFrequency",
-          android_hyphenationFrequency)};
+          "android_hyphenationFrequency", android_hyphenationFrequency)};
 }
 #endif
 

ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h

@@ -45,7 +45,7 @@ class ParagraphAttributes : public DebugStringConvertible {
   /*
    * (Android only) Break strategy for breaking paragraphs into lines.
    */
-  TextBreakStrategy textBreakStrategy{};
+  TextBreakStrategy textBreakStrategy{TextBreakStrategy::HighQuality};
 
   /*
    * Enables font size adjustment to fit constrained boundaries.
@@ -59,7 +59,8 @@ class ParagraphAttributes : public DebugStringConvertible {
   bool includeFontPadding{true};
 
   /*
-   * (Android only) Frequency of automatic hyphenation to use when determining word breaks.
+   * (Android only) Frequency of automatic hyphenation to use when determining
+   * word breaks.
    */
   HyphenationFrequency android_hyphenationFrequency{};
 

ReactCommon/react/renderer/attributedstring/conversions.h

@@ -96,7 +96,7 @@ inline std::string toString(const TextBreakStrategy &textBreakStrategy) {
 
   LOG(ERROR) << "Unsupported TextBreakStrategy value";
   react_native_assert(false);
-  return "simple";
+  return "highQuality";
 }
 
 inline void fromRawValue(
@@ -116,14 +116,14 @@ inline void fromRawValue(
       // sane default
       LOG(ERROR) << "Unsupported TextBreakStrategy value: " << string;
       react_native_assert(false);
-      result = TextBreakStrategy::Simple;
+      result = TextBreakStrategy::HighQuality;
     }
     return;
   }
 
   LOG(ERROR) << "Unsupported TextBreakStrategy type";
   react_native_assert(false);
-  result = TextBreakStrategy::Simple;
+  result = TextBreakStrategy::HighQuality;
 }
 
 inline void fromRawValue(

ReactCommon/react/renderer/attributedstring/primitives.h

@@ -55,8 +55,8 @@ enum class EllipsizeMode {
 
 enum class TextBreakStrategy {
   Simple, // Simple strategy.
-  Balanced, // Balances line lengths.
-  HighQuality // High-quality strategy, including hyphenation.
+  HighQuality, // High-quality strategy, including hyphenation.
+  Balanced // Balances line lengths.
 };
 
 enum class TextAlignment {