Delete empty didRegisterUserNotificationSettings (#41013)

Summary: Pull Request resolved: #41013 ## Changelog: [iOS][Breaking] Deleted the no-op didRegisterUserNotificationSettings: callback in RCTPushNotificationManager Reviewed By: philIip Differential Revision: D50283620 fbshipit-source-id: 1582367c51c26e5b739cd9284d3b15bfa13274da
facebook · Oct 17, 2023 · 3bea8e1 · 3bea8e1
1 parent bb9cc0c
commit 3bea8e1
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 12 deletions.
diff --git a/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.h b/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.h
@@ -14,7 +14,6 @@ extern NSString *const RCTRemoteNotificationReceived;
 typedef void (^RCTRemoteNotificationCallback)(UIBackgroundFetchResult result);
 
 #if !TARGET_OS_UIKITFORMAC
-+ (void)didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings;
 + (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken;
 + (void)didReceiveRemoteNotification:(NSDictionary *)notification;
 + (void)didReceiveRemoteNotification:(NSDictionary *)notification

diff --git a/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm b/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm
@@ -176,10 +176,6 @@ - (void)stopObserving
   ];
 }
 
-+ (void)didRegisterUserNotificationSettings:(__unused UIUserNotificationSettings *)notificationSettings
-{
-}
-
 + (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
 {
   NSMutableString *hexString = [NSMutableString string];

diff --git a/packages/rn-tester/RNTester/AppDelegate.mm b/packages/rn-tester/RNTester/AppDelegate.mm
@@ -88,13 +88,6 @@ - (void)loadSourceForBridge:(RCTBridge *)bridge
 
 #if !TARGET_OS_TV && !TARGET_OS_UIKITFORMAC
 
-// Required to register for notifications
-- (void)application:(__unused UIApplication *)application
-    didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings
-{
-  [RCTPushNotificationManager didRegisterUserNotificationSettings:notificationSettings];
-}
-
 // Required for the remoteNotificationsRegistered event.
 - (void)application:(__unused UIApplication *)application
     didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
-Original file line number
+Diff line change
@@ Expand Up / @@ -176,10 +176,6 @@ - (void)stopObserving @@
       ];
     }
-    + (void)didRegisterUserNotificationSettings:(__unused UIUserNotificationSettings *)notificationSettings
-    {
-    }
     + (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
     {
       NSMutableString *hexString = [NSMutableString string];
@@ Expand Down @@