Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix textShadowOffset error without width or height
Summary: textShadowOffset design is `ReactPropTypes.shape({width: ReactPropTypes.number, height: ReactPropTypes.number})`, so either width or height is optional. Unfortunately, in Android implementation, it is my bad not handling optional case and lead to an exception. Thanks kohver for reporting [this issue](#4975 (comment)) **Test plan (required)** *Before this fix* 1. Modify TextExample.android.js to `<Text style={{fontSize: 20, textShadowOffset: {height: 10}, textShadowRadius: 1, textShadowColor: '#00cccc'}}>` which really raise a redbox. *After this fix* 1. Test original TextExample.android.js textShadowOffset works well. 2. Modify TextExample.android.js to `<Text style={{fontSize: 20, textShadowOffset: {height: 10}, textShadowRadius: 1, textShadowColor: '#00cccc'}}>` which works well without redbox. Closes #7119 Differential Revision: D3240607 Pulled By: mkonicek fb-gh-sync-id: b13221ae1586594890b0f4aa644ace7c0d5d6c58 fbshipit-source-id: b13221ae1586594890b0f4aa644ace7c0d5d6c58
- Loading branch information