Skip to content

Commit

Permalink
Consume Hermes from Maven in release (#35116)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #35116

This diff let release versions of React Native to consume the Hermes tarball from Maven.

It is already setup to download proper debug/release version

## Changelog
[iOS][Added] - Download Hermes from Maven while for -stables

Reviewed By: cortinico

Differential Revision: D40794707

fbshipit-source-id: b6fa44a272ca044e1c4057a08accecb2009ad312
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Oct 28, 2022
1 parent 3dc7b37 commit 44e8462
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 3 additions & 1 deletion sdks/hermes-engine/hermes-engine.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ elsif File.exists?(hermestag_file) && isInCI
source[:git] = git
source[:tag] = hermestag
else
source[:http] = "https://github.com/facebook/react-native/releases/download/v#{version}/hermes-runtime-darwin-#{build_type.to_s}-v#{version}.tar.gz"
# Sample url from Maven:
# https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/0.71.0/react-native-artifacts-0.71.0-hermes-ios-debug.tar.gz
source[:http] = "https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/#{version}/react-native-artifacts-#{version}-hermes-ios-#{build_type.to_s}.tar.gz"
end

Pod::Spec.new do |spec|
Expand Down
1 change: 0 additions & 1 deletion sdks/hermes-engine/hermes-utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# - version: the version of React Native that requires the Hermes tarball
# Returns: the path to the downloaded Hermes tarball
def download_nightly_hermes(react_native_path, version)
# TODO: convert hermes-ios to hermes-ios-debug
params = "r=snapshots\&g=com.facebook.react\&a=react-native-artifacts\&c=hermes-ios-debug\&e=tar.gz\&v=#{version}-SNAPSHOT"
tarball_url = "http://oss.sonatype.org/service/local/artifact/maven/redirect\?#{params}"

Expand Down

0 comments on commit 44e8462

Please sign in to comment.