Skip to content

Commit

Permalink
Fix release infrastructure failures discovered during .69 release
Browse files Browse the repository at this point in the history
Summary:
During the release of .69, we (fortmarek and me) discovered a couple of bits that needed
some intervention.
- `sdks/.hermesversion` was gitignored, so we could not commit that.
- `scripts/bump-hermes-version.js` was not executable, so we had to chmod +x to
  make it runnable.

Here I'm fixing it.

Changelog:
[Internal] [Changed] - Fix release infrastructure failures discovered during .69 release

Reviewed By: cipolleschi

Differential Revision: D36003808

fbshipit-source-id: c4d82ed5e2c63988699035ac84b0e87ed8894540
  • Loading branch information
cortinico authored and facebook-github-bot committed Apr 28, 2022
1 parent 208422f commit 4ea593b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ package-lock.json
/packages/rn-tester/NativeModuleExample/ScreenshotManagerSpec*

# Additional SDKs
/sdks/.hermesversion
/sdks/hermes
/sdks/download

Expand Down
1 change: 1 addition & 0 deletions scripts/bump-hermes-version.js
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

/**
* This script walks a releaser through bumping the Hermes version for a release.
* It needs be executed on a release branch.
*/
const {exit} = require('shelljs');
const yargs = require('yargs');
Expand Down

0 comments on commit 4ea593b

Please sign in to comment.