Test Xcode 10 (#21324)

Summary:
This also fixes an issue with tagged commit Circle CI jobs, and avoids running the `publish_npm_package` on every commit. The new config ignores commits on *all branches*, but should still catch git tags.
Pull Request resolved: #21324

Differential Revision: D10041629

Pulled By: hramos

fbshipit-source-id: 9b3295b5fcd614c67a8838ffd49c6a5d6ae7fd86

.circleci/config.yml

@@ -434,6 +434,32 @@ jobs:
       - store_test_results:
           path: ~/react-native/reports/junit
 
+  # Xcode 10: Runs unit tests on iOS and Apple TV devices
+  test_objc_xcode10:
+    <<: *defaults
+    macos:
+      xcode: "10.0.0"
+    steps:
+      - checkout
+      - run: *setup-artifacts
+      - run: *yarn
+
+      - run: *boot-simulator-iphone
+      - run: *boot-simulator-appletv
+      - run: *brew-install-watchman
+
+      - run: *run-objc-ios-tests
+      - run: *run-objc-tvos-tests
+
+      # TODO: Fix these failing tests.
+      - run: *display-broken-tests-warning
+      - run: *run-podspec-tests
+      - run: *run-objc-ios-e2e-tests
+      - run: *run-objc-tvos-e2e-tests
+
+      - store_test_results:
+          path: ~/react-native/reports/junit
+
   # Runs end to end tests (Detox)
   test_detox_end_to_end:
     <<: *macos_defaults
@@ -653,10 +679,6 @@ workflows:
           requires:
             - checkout_code
 
-      # Test JavaScript and Node 10 compatibility
-      - test_node10:
-          filters: *filter-ignore-gh-pages
-
       # Test Android
       - test_android:
           filters: *filter-ignore-gh-pages
@@ -674,9 +696,19 @@ workflows:
           requires:
             - checkout_code
 
+      # Tooling Compatibility Checks
+      - test_objc_xcode10:
+          filters: *filter-ignore-gh-pages
+      - test_node10:
+          filters: *filter-ignore-gh-pages
+
       # Only runs on vX.X.X tags if all tests are green
       - publish_npm_package:
           filters:
+            # ignore any commit on any branch by default
+            branches:
+              ignore: /.*/
+            # only act on version tags
             tags:
               only: /v[0-9]+(\.[0-9]+)*(\-rc(\.[0-9]+)?)?/
           requires: