Skip to content

Commit

Permalink
Remove RFC-0759 ram-bundle command from cli (#43292)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #43292

The ram-bundle command isn't necessary now that Hermes is our default VM.  The RFC specifically calls for the CLI command to be removed [1].

[1] https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0759-react-native-frameworks.md#commands-to-be-removed

Changelog:
[General][Removed] - RFC-0759 remove ram-bundle command.

Reviewed By: NickGerleman, cipolleschi

Differential Revision: D54430289

fbshipit-source-id: 49d519c007b739f89ffe9032fec905c56ea49f4a
  • Loading branch information
blakef authored and facebook-github-bot committed Mar 4, 2024
1 parent 6461dcd commit 58b45e8
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 59 deletions.
18 changes: 0 additions & 18 deletions packages/community-cli-plugin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,24 +69,6 @@ npx react-native bundle --entry-file <path> [options]
| `--read-global-cache` | Attempt to fetch transformed JS code from the global cache, if configured. Defaults to `false`. |
| `--config <string>` | Path to the CLI configuration file. |

### `ram-bundle`

Build the [RAM bundle](https://reactnative.dev/docs/ram-bundles-inline-requires) for the provided JavaScript entry file.

#### Usage

```sh
npx react-native ram-bundle --entry-file <path> [options]
```

#### Options

Accepts all options supported by [`bundle`](#bundle) and the following:

| Option | Description |
| - | - |
| `--indexed-ram-bundle` | Force the "Indexed RAM" bundle file format, even when building for Android. |

## Contributing

Changes to this package can be made locally and tested against the `rn-tester` app, per the [Contributing guide](https://reactnative.dev/contributing/overview#contributing-code). During development, this package is automatically run from source with no build step.
38 changes: 0 additions & 38 deletions packages/community-cli-plugin/src/commands/ram-bundle/index.js

This file was deleted.

1 change: 0 additions & 1 deletion packages/community-cli-plugin/src/index.flow.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
*/

export {default as bundleCommand} from './commands/bundle';
export {default as ramBundleCommand} from './commands/ram-bundle';
export {default as startCommand} from './commands/start';

export {unstable_buildBundleWithConfig} from './commands/bundle/buildBundle';
2 changes: 0 additions & 2 deletions packages/react-native/react-native.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const android = require('@react-native-community/cli-platform-android');
const ios = require('@react-native-community/cli-platform-ios');
const {
bundleCommand,
ramBundleCommand,
startCommand,
} = require('@react-native/community-cli-plugin');

Expand Down Expand Up @@ -49,7 +48,6 @@ module.exports = {
...ios.commands,
...android.commands,
bundleCommand,
ramBundleCommand,
startCommand,
codegenCommand,
],
Expand Down

0 comments on commit 58b45e8

Please sign in to comment.