Remove overflow hidden killswitch

Summary: There hasn't been any reports of overflow issues since the last issue was fixed in v183 (July 30th). Let's remove this flag Reviewed By: yungsters Differential Revision: D10020006 fbshipit-source-id: 593c7d2c2bef5f0bd60d5de1941cd58f7fd6ccc7
facebook · Sep 25, 2018 · 59aada8 · 59aada8
1 parent 0a04bb7
commit 59aada8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java b/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java
@@ -112,9 +112,7 @@ public ReactRootView(Context context, AttributeSet attrs, int defStyle) {
   }
 
   private void init() {
-    if (!ViewProps.sDefaultOverflowHidden) {
-      setClipChildren(false);
-    }
+    setClipChildren(false);
   }
 
   @Override

diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewProps.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewProps.java
@@ -17,11 +17,6 @@
  */
 public class ViewProps {
 
-  /**
-   * Kill switch to make overflow hidden by default. This flag will eventually be removed.
-   */
-  public static boolean sDefaultOverflowHidden;
-
   public static final String VIEW_CLASS_NAME = "RCTView";
 
   // Layout only (only affect positions of children, causes no drawing)

diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java b/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java
@@ -115,10 +115,7 @@ public void onLayoutChange(
 
   public ReactViewGroup(Context context) {
     super(context);
-    // TODO: Remove this check after a couple public releases.
-    if (!ViewProps.sDefaultOverflowHidden) {
-      setClipChildren(false);
-    }
+    setClipChildren(false);
     mDrawingOrderHelper = new ViewGroupDrawingOrderHelper(this);
   }