-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
Summary: Pull Request resolved: #36795 This change bump the min iOS version for React Native to 13.4, to align with company guidelines. ## Changelog: [iOS][Changed] - Moved the min iOS version to 13.4 Reviewed By: cortinico Differential Revision: D44634663 fbshipit-source-id: 035e8fcbb395f7394f8253e3ec485ad9937531c2
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ Pod::Spec.new do |s| | |
s.documentation_url = "https://reactnative.dev/docs/actionsheetios" | ||
s.license = package["license"] | ||
s.author = "Meta Platforms, Inc. and its affiliates" | ||
s.platforms = { :ios => "12.4" } | ||
s.platforms = { :ios => min_ios_version_supported } | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
stevenpetryk
|
||
s.source = source | ||
s.source_files = "*.{m}" | ||
s.preserve_paths = "package.json", "LICENSE", "LICENSE-docs" | ||
|
I want to point out that having these podspecs depend on function defined in another podspec breaks CocoaPods commands that inspect single podspecs. For example, if you run:
CocoaPods fails with a NoMethodError on
min_ios_version_supported
.When this was done, I think a
require_relative
should have been added to these podspecs to ensure the method is defined before it's referenced. It's odd, in general, to make some podspecs depend on the alterations to the global namespace caused by another.