-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
kill RCTFabricSurfaceHostingProxyRootView (#38864)
Summary: Pull Request resolved: #38864 ## Changelog: [iOS][Breaking] - Deleting RCTFabricSurfaceHostingProxyRootView We currently have 3 different container view classes in new architecture: `RCTFabricSurfaceHostingProxyRootView`, `RCTSurfaceHostingProxyRootView`, and `RCTSurfaceHostingView`. it's a little complicated for the current use case, so there's an opportunity to simplify. in this PR, i get rid of `RCTFabricSurfaceHostingProxyRootView` by relying on the composable behavior of surface and host views instead of existing internal reflection logic that depends on inheritance. these are cleaned up in D48140101 and D48140317. i checked GH search and no one is really using this in a fundamental way. bypass-github-export-checks Reviewed By: cipolleschi Differential Revision: D48139820 fbshipit-source-id: 068b994a8b068a4107397f1862356b8fa1da961f
- Loading branch information
1 parent
02408e1
commit 676676c
Showing
6 changed files
with
17 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 0 additions & 15 deletions
15
packages/react-native/React/Fabric/Surface/RCTFabricSurfaceHostingProxyRootView.h
This file was deleted.
Oops, something went wrong.
21 changes: 0 additions & 21 deletions
21
packages/react-native/React/Fabric/Surface/RCTFabricSurfaceHostingProxyRootView.mm
This file was deleted.
Oops, something went wrong.