Skip to content

Commit

Permalink
reduce noisy systrace sections
Browse files Browse the repository at this point in the history
Summary:
changelog: [internal]

this is not needed anymore. let's remove it.

Reviewed By: dmytrorykun

Differential Revision: D61717151
  • Loading branch information
sammy-SC authored and facebook-github-bot committed Aug 23, 2024
1 parent a8be335 commit 69890e0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
const PropsParserContext& context,
const Props::Shared& props,
RawProps rawProps) const override {
SystraceSection s1("ConcreteComponentDescriptor::cloneProps");
// Optimization:
// Quite often nodes are constructed with default/empty props: the base
// `props` object is `null` (there no base because it's not cloning) and the
Expand All @@ -125,8 +124,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
#else
const auto& dynamic = static_cast<folly::dynamic>(rawProps);
#endif
SystraceSection s2(
"ConcreteComponentDescriptor::cloneProps - iterateOverValues");
for (const auto& pair : dynamic.items()) {
const auto& name = pair.first.getString();
shadowNodeProps->setProp(
Expand All @@ -137,8 +134,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
}
return shadowNodeProps;
} else {
SystraceSection s3(
"ConcreteComponentDescriptor::cloneProps - old-style constructor");
// Call old-style constructor
return ShadowNodeT::Props(context, rawProps, props);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ RawProps& RawProps::operator=(const RawProps& other) noexcept {
}

void RawProps::parse(const RawPropsParser& parser) noexcept {
SystraceSection s("RawProps::parse");
react_native_assert(parser_ == nullptr && "A parser was already assigned.");
parser_ = &parser;
parser.preparse(*this);
Expand All @@ -174,7 +173,6 @@ void RawProps::parse(const RawPropsParser& parser) noexcept {
* will be removed as soon Android implementation does not need it.
*/
RawProps::operator folly::dynamic() const noexcept {
SystraceSection s("RawProps::operator folly::dynamic()");
switch (mode_) {
case Mode::Empty:
return folly::dynamic::object();
Expand Down

0 comments on commit 69890e0

Please sign in to comment.