Remove DevSplitBundleLoader

Summary: Changelog: [General][Removed] Remove internal DevSplitBundleLoader native module `DevSplitBundleLoader` was part of an experimental bundling strategy that offloaded Hermes bytecode compilation to the packager server. The React Native parts of this experiment were never part of the public API, and the Metro parts never fully shipped in open source. As part of implementing the simpler and more general [lazy bundling RFC](react-native-community/discussions-and-proposals#605), we are removing `DevSplitBundleLoader` and associated code from React Native's internals. Reviewed By: robhogan Differential Revision: D43597007 fbshipit-source-id: 1460e9045cd7a0f5ef43144b10afb932172e223c
facebook · Mar 21, 2023 · 6dcdb93 · 6dcdb93
1 parent fdb2af5
commit 6dcdb93
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 224 deletions.
diff --git a/packages/react-native/Libraries/Utilities/NativeDevSplitBundleLoader.js b/packages/react-native/Libraries/Utilities/NativeDevSplitBundleLoader.js
diff --git a/packages/react-native/React/CoreModules/BUCK b/packages/react-native/React/CoreModules/BUCK
@@ -110,9 +110,6 @@ rn_apple_library(
         ) + react_module_plugin_providers(
             name = "DevLoadingView",
             native_class_func = "RCTDevLoadingViewCls",
-        ) + react_module_plugin_providers(
-            name = "DevSplitBundleLoader",
-            native_class_func = "RCTDevSplitBundleLoaderCls",
         ) + react_module_plugin_providers(
             name = "EventDispatcher",
             native_class_func = "RCTEventDispatcherCls",

diff --git a/packages/react-native/React/CoreModules/CoreModulesPlugins.h b/packages/react-native/React/CoreModules/CoreModulesPlugins.h
@@ -51,7 +51,6 @@ Class RCTLogBoxCls(void) __attribute__((used));
 Class RCTWebSocketExecutorCls(void) __attribute__((used));
 Class RCTWebSocketModuleCls(void) __attribute__((used));
 Class RCTDevLoadingViewCls(void) __attribute__((used));
-Class RCTDevSplitBundleLoaderCls(void) __attribute__((used));
 Class RCTEventDispatcherCls(void) __attribute__((used));
 Class RCTBlobManagerCls(void) __attribute__((used));
 

diff --git a/packages/react-native/React/CoreModules/CoreModulesPlugins.mm b/packages/react-native/React/CoreModules/CoreModulesPlugins.mm
@@ -41,7 +41,6 @@ Class RCTCoreModulesClassProvider(const char *name) {
     {"WebSocketExecutor", RCTWebSocketExecutorCls},
     {"WebSocketModule", RCTWebSocketModuleCls},
     {"DevLoadingView", RCTDevLoadingViewCls},
-    {"DevSplitBundleLoader", RCTDevSplitBundleLoaderCls},
     {"EventDispatcher", RCTEventDispatcherCls},
     {"BlobModule", RCTBlobManagerCls},
   };

diff --git a/packages/react-native/React/CoreModules/RCTDevSplitBundleLoader.h b/packages/react-native/React/CoreModules/RCTDevSplitBundleLoader.h
diff --git a/packages/react-native/React/CoreModules/RCTDevSplitBundleLoader.mm b/packages/react-native/React/CoreModules/RCTDevSplitBundleLoader.mm
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/BUCK b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/BUCK
@@ -39,7 +39,6 @@ rn_android_library(
         react_native_target("java/com/facebook/react/module/model:model"),
         react_native_target("java/com/facebook/react/modules/appearance:appearance"),
         react_native_target("java/com/facebook/react/modules/appregistry:appregistry"),
-        react_native_target("java/com/facebook/react/modules/bundleloader:bundleloader"),
         react_native_target("java/com/facebook/react/modules/debug:debug"),
         react_native_target("java/com/facebook/react/modules/debug:interfaces"),
         react_native_target("java/com/facebook/react/modules/deviceinfo:deviceinfo"),

diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java
@@ -21,7 +21,6 @@
 import com.facebook.react.module.annotations.ReactModuleList;
 import com.facebook.react.module.model.ReactModuleInfo;
 import com.facebook.react.module.model.ReactModuleInfoProvider;
-import com.facebook.react.modules.bundleloader.NativeDevSplitBundleLoaderModule;
 import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
 import com.facebook.react.modules.core.DeviceEventManagerModule;
 import com.facebook.react.modules.core.ExceptionsManagerModule;
@@ -57,7 +56,6 @@
       SourceCodeModule.class,
       TimingModule.class,
       UIManagerModule.class,
-      NativeDevSplitBundleLoaderModule.class,
     })
 public class CoreModulesPackage extends TurboReactPackage implements ReactPackageLogger {
 
@@ -103,7 +101,6 @@ public ReactModuleInfoProvider getReactModuleInfoProvider() {
             SourceCodeModule.class,
             TimingModule.class,
             UIManagerModule.class,
-            NativeDevSplitBundleLoaderModule.class,
           };
 
       final Map<String, ReactModuleInfo> reactModuleInfoMap = new HashMap<>();
@@ -160,9 +157,6 @@ public NativeModule getModule(String name, ReactApplicationContext reactContext)
         return createUIManager(reactContext);
       case DeviceInfoModule.NAME:
         return new DeviceInfoModule(reactContext);
-      case NativeDevSplitBundleLoaderModule.NAME:
-        return new NativeDevSplitBundleLoaderModule(
-            reactContext, mReactInstanceManager.getDevSupportManager());
       default:
         throw new IllegalArgumentException(
             "In CoreModulesPackage, could not find Native module for " + name);

diff --git a/...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/bundleloader/BUCK b/...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/bundleloader/BUCK
diff --git a/...c/main/java/com/facebook/react/modules/bundleloader/NativeDevSplitBundleLoaderModule.java b/...c/main/java/com/facebook/react/modules/bundleloader/NativeDevSplitBundleLoaderModule.java