Only show DevMenu on shake if RCTView is visible

Summary: Changelog: [iOS] Only show Dev Menu on shake if RN view is visible Reviewed By: fkgozali Differential Revision: D26138659 fbshipit-source-id: e2db287728675c7ead5fcbf569ed591638e2187e
facebook · Jan 29, 2021 · 7186c4d · 7186c4d
1 parent b0ec350
commit 7186c4d
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/React/CoreModules/RCTDevMenu.mm b/React/CoreModules/RCTDevMenu.mm
@@ -168,7 +168,13 @@ - (void)invalidate
 - (void)showOnShake
 {
   if ([((RCTDevSettings *)[_moduleRegistry moduleForName:"DevSettings"]) isShakeToShowDevMenuEnabled]) {
-    [self show];
+    for (UIWindow *window in [RCTSharedApplication() windows]) {
+      NSString *recursiveDescription = [window valueForKey:@"recursiveDescription"];
+      if ([recursiveDescription containsString:@"RCTView"]) {
+        [self show];
+        return;
+      }
+    }
   }
 }