Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hide the logbox window explicitly. New behavior in iOS SDK appears to… (
#32435) Summary: Fixes #32434: RCTLogBox window is orphaned, covering entire screen. After this change, the logbox window once again is removed from the screen. ## Changelog Some third-party SDKs may hold references to created UIWindow, UIViewController, or UIView objects. Doing so means that the current code's `hide` method that releases the reference to the UIWindow in LogBox will not cause the window to be dealloc'd, and thus instead it will remain on the screen. This change explicitly hides the LogBox window when the reference is released, so that even if some other SDK holds onto the window it will still be taken off the screen. <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - 32434 Pull Request resolved: #32435 Test Plan: 1. Use console.warn to generate a yellow warning message in log box. Also install a third-party SDK that holds onto a reference to UIWindow -- for example the Facebook SDK, the Data Dog SDK, or any number of other SDKs that use `swizzling` to intercept calls like `viewDidAppear:`. 2. click the log 3. tap "dismiss" 4. try to tap anywhere 5. Use Xcode view debugger to inspect the UI state ## Expected The app still responds to the touch. In Xcode, there is not an extra UIWindow covering the screen Reviewed By: philIip Differential Revision: D31794242 Pulled By: sshic fbshipit-source-id: 28aa247b3ed3fd60b8e7c2ed7d0606cbf5c42408
- Loading branch information