Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Detach thread in executeAsynchronously (RuntimeExecutor.h) (#31090)
Summary: std::thread's constructor is nodiscard. This breaks in MSVC 16.9 when nodiscard starts to be enforced. Either we should hold on to the created object or detach the temporary which is what I think this function intends to do anyway. Fixes #31088 Fixes an invalid usage of std::thread's constructor ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - fixes usage of std::thread in runtime executor Pull Request resolved: #31090 Reviewed By: sammy-SC Differential Revision: D26783963 Pulled By: appden fbshipit-source-id: fed4d072792aafa058dd742e8fce30a207f991c1
- Loading branch information