Ensure LogBoxView is sized based on the "window" size instead of the …

…"screen" size

Summary:
In iOS, the native LogBox that gets rendered for JS errors/warnings is statically sized once and bases that size off of the entire screen's size. This causes issues when being run in a Mac Catalyst app since 1) the sizing is not static since we can resize the window and 2) the size of the LogBox's root should fill the *window* and not the screen. This diff fixes both of these issues.

Changelog:
[iOS][Fixed] - Ensure LogBoxView is sized relative to the key window instead of the full screen

Reviewed By: appden

Differential Revision: D34697076

fbshipit-source-id: 9665fd51bc86ed29837672cec882bac97904b0c8

React/CoreModules/RCTLogBox.mm

@@ -51,8 +51,7 @@ + (BOOL)requiresMainQueueSetup
 
       if (strongSelf->_bridge) {
         if (strongSelf->_bridge.valid) {
-          strongSelf->_view = [[RCTLogBoxView alloc] initWithFrame:[UIScreen mainScreen].bounds
-                                                            bridge:strongSelf->_bridge];
+          strongSelf->_view = [[RCTLogBoxView alloc] initWithFrame:RCTKeyWindow().frame bridge:strongSelf->_bridge];
           [strongSelf->_view show];
         }
       } else {

React/CoreModules/RCTLogBoxView.mm

@@ -39,9 +39,8 @@ - (instancetype)initWithFrame:(CGRect)frame bridge:(RCTBridge *)bridge
     self.backgroundColor = [UIColor clearColor];
 
     _surface = [[RCTSurface alloc] initWithBridge:bridge moduleName:@"LogBox" initialProperties:@{}];
-
-    [_surface start];
     [_surface setSize:frame.size];
+    [_surface start];
 
     if (![_surface synchronouslyWaitForStage:RCTSurfaceStageSurfaceDidInitialMounting timeout:1]) {
       RCTLogInfo(@"Failed to mount LogBox within 1s");
@@ -52,6 +51,12 @@ - (instancetype)initWithFrame:(CGRect)frame bridge:(RCTBridge *)bridge
   return self;
 }
 
+- (void)layoutSubviews
+{
+  [super layoutSubviews];
+  [_surface setSize:self.frame.size];
+}
+
 - (void)dealloc
 {
   [RCTSharedApplication().delegate.window makeKeyWindow];