-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Exposing this enum is essentially useless and at worst is a runtime cost that isn't necessary by just using the string. The value of this enum, as far as I understand it, is to enforce that only valid options are used. We can enforce this at build time with Flow. I was able to migrate our codebase with a few Find and Replace for things like ``` resizeMode={Image.resizeMode.contain} ``` Reviewed By: yungsters Differential Revision: D7983982 fbshipit-source-id: ddd7024023f8d2f01aad1fff6c8103983a1bec1a
- Loading branch information
1 parent
a9a612b
commit 870775e
Showing
4 changed files
with
7 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters