Fix Hermes warnings/errors from stricter compiler settings in Horizon

Summary: Changelog: [Internal][Fixed] Fixed strict compiler errors and warnings Reviewed By: mattbfb Differential Revision: D42217295 fbshipit-source-id: 0943a4f6f5607f9499c7c92d6627877260d749fb
facebook · Jan 9, 2023 · 9e0cb5a · 9e0cb5a
1 parent 0ff7b7f
commit 9e0cb5a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/ReactCommon/hermes/inspector/Inspector.h b/ReactCommon/hermes/inspector/Inspector.h
@@ -109,7 +109,7 @@ class Inspector : public facebook::hermes::debugger::EventObserver,
       std::shared_ptr<RuntimeAdapter> adapter,
       InspectorObserver &observer,
       bool pauseOnFirstStatement);
-  ~Inspector();
+  ~Inspector() override;
 
   /**
    * disable turns off the inspector. All of the subsequent methods will not do

diff --git a/ReactCommon/hermes/inspector/InspectorState.h b/ReactCommon/hermes/inspector/InspectorState.h
@@ -184,7 +184,7 @@ class InspectorState::RunningDetached : public InspectorState {
   }
 
   RunningDetached(Inspector &inspector) : InspectorState(inspector) {}
-  ~RunningDetached() {}
+  ~RunningDetached() override {}
 
   std::pair<NextStatePtr, CommandPtr> didPause(MonitorLock &lock) override;
   std::pair<NextStatePtr, bool> enable() override;
@@ -211,7 +211,7 @@ class InspectorState::RunningWaitEnable : public InspectorState {
   }
 
   RunningWaitEnable(Inspector &inspector) : InspectorState(inspector) {}
-  ~RunningWaitEnable() {}
+  ~RunningWaitEnable() override {}
 
   std::pair<NextStatePtr, CommandPtr> didPause(MonitorLock &lock) override;
   std::pair<NextStatePtr, bool> enable() override;
@@ -260,7 +260,7 @@ class InspectorState::PausedWaitEnable : public InspectorState {
   }
 
   PausedWaitEnable(Inspector &inspector) : InspectorState(inspector) {}
-  ~PausedWaitEnable() {}
+  ~PausedWaitEnable() override {}
 
   std::pair<NextStatePtr, CommandPtr> didPause(MonitorLock &lock) override;
   std::pair<NextStatePtr, bool> enable() override;
@@ -306,7 +306,7 @@ class InspectorState::Running : public InspectorState {
   }
 
   Running(Inspector &inspector) : InspectorState(inspector) {}
-  ~Running() {}
+  ~Running() override {}
 
   void onEnter(InspectorState *prevState) override;
 
@@ -366,7 +366,7 @@ class InspectorState::Paused : public InspectorState {
   }
 
   Paused(Inspector &inspector) : InspectorState(inspector) {}
-  ~Paused() {}
+  ~Paused() override {}
 
   void onEnter(InspectorState *prevState) override;
 

diff --git a/ReactCommon/hermes/inspector/detail/SerialExecutor.h b/ReactCommon/hermes/inspector/detail/SerialExecutor.h
@@ -36,7 +36,7 @@ namespace detail {
 class SerialExecutor : public folly::Executor {
  public:
   SerialExecutor(const std::string &name);
-  ~SerialExecutor();
+  ~SerialExecutor() override;
 
   void add(folly::Func) override;