Skip to content

Commit

Permalink
Apply lint updates from buildifier in xplat
Browse files Browse the repository at this point in the history
Summary:
In D37873933, we update the buildifier binaries, which apply some minor changes to existing lint. Specifically, entries are now properly sorted.

Update the files in xplat such that updating buildifier does not cause lint changes in users diffs.

drop-conflicts
allow_many_files
#nocancel
#forcetdhashing

(Note: this ignores all push blocking failures!)

Reviewed By: d16r

Differential Revision: D37873936

fbshipit-source-id: f31d9c50d64ae99f99298977b471bf13e7ed5262
  • Loading branch information
chatura-atapattu authored and facebook-github-bot committed Jul 24, 2022
1 parent a67360b commit a70354d
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ fb_native.genrule(
) + [
react_native_root_target("packages/rn-tester:nativecomponent-srcs"),
],
labels = ["uses_hg"],
cmd = "$(exe {}) $OUT $SRCS".format(react_native_root_target("packages/react-native-codegen:write_to_json")),
out = "schema-rncore.json",
cmd = "$(exe {}) $OUT $SRCS".format(react_native_root_target("packages/react-native-codegen:write_to_json")),
labels = ["uses_hg"],
)

rn_codegen_components(
Expand Down
2 changes: 1 addition & 1 deletion ReactAndroid/src/main/libraries/fbjni/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")

fb_native.android_library(
name = "java",
visibility = ["PUBLIC"],
exported_deps = [
":fbjni-binary",
],
visibility = ["PUBLIC"],
)

fb_native.android_prebuilt_aar(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")

fb_native.android_library(
name = "soloader",
visibility = ["PUBLIC"],
exported_deps = [
":annotation-binary",
":nativeloader-binary",
":soloader-binary",
],
visibility = ["PUBLIC"],
)

fb_native.prebuilt_jar(
Expand Down
4 changes: 2 additions & 2 deletions ReactAndroid/src/main/third-party/kotlin/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ fb_native.remote_file(

fb_native.genrule(
name = "kotlin-compiler-download",
type = "copy",
srcs = [
":annotations-13.0.jar",
":kotlin-annotation-processing.jar",
Expand All @@ -94,9 +93,10 @@ fb_native.genrule(
":kotlin-stdlib.jar",
":trove4j.jar",
],
out = "kotlin-compiler-out",
cmd = "mkdir ${OUT} && cp ${SRCS} ${OUT}",
cmd_exe = "@powershell -Command Copy-Item '${SRCS}' '${OUT}'",
out = "kotlin-compiler-out",
type = "copy",
)

fb_native.remote_file(
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-codegen/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ fb_native.genrule(
"**/e2e/__test_fixtures__/modules/Native*.js",
],
),
cmd = "$(exe {}) $OUT $SRCS".format(react_native_root_target("packages/react-native-codegen:write_to_json")),
out = "schema-codegen_tests.json",
cmd = "$(exe {}) $OUT $SRCS".format(react_native_root_target("packages/react-native-codegen:write_to_json")),
)

rn_codegen_components(
Expand Down

0 comments on commit a70354d

Please sign in to comment.