Skip to content

Commit

Permalink
Add link group label to talkios deps (#34949)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #34949

Changelog: [Internal]

Currently, link groups depend on supermodules to generate. To continue supporting link groups while allowing us to migrate off supermodules, we'll add a talkios_link_group label on all talkios targets to persist the current hierarchical information.

Reviewed By: jkeljo

Differential Revision: D40268275

fbshipit-source-id: a82e969e7cb8ec167489be73dc9bc71cf8ec37e1
  • Loading branch information
Chenglin Liu authored and facebook-github-bot committed Oct 12, 2022
1 parent 21c8837 commit a885b1f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
6 changes: 6 additions & 0 deletions BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,7 @@ rn_apple_library(
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
"talkios_link_group:xplat/default/public.react_native.infra",
],
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(),
reexport_all_header_dependencies = True,
Expand Down Expand Up @@ -834,6 +835,7 @@ rn_apple_library(
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
"talkios_link_group:xplat/default/public.react_native.infra",
],
plugins =
react_module_plugin_providers(
Expand Down Expand Up @@ -945,6 +947,7 @@ rn_apple_library(
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
"talkios_link_group:xplat/default/public.react_native.infra",
],
plugins =
react_module_plugin_providers(
Expand Down Expand Up @@ -994,6 +997,7 @@ rn_apple_library(
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
"talkios_link_group:xplat/default/public.react_native.infra",
],
plugins =
react_module_plugin_providers(
Expand Down Expand Up @@ -1047,6 +1051,7 @@ rn_apple_library(
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
"talkios_link_group:xplat/default/public.react_native.infra",
],
plugins =
react_module_plugin_providers(
Expand Down Expand Up @@ -1129,6 +1134,7 @@ rn_apple_library(
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
"talkios_link_group:xplat/default/public.react_native.infra",
],
plugins =
react_module_plugin_providers(
Expand Down
1 change: 1 addition & 0 deletions Libraries/FBLazyVector/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ fb_apple_library(
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
"talkios_link_group:xplat/default/public.react_native.infra",
],
link_whole = False,
visibility = ["PUBLIC"],
Expand Down
1 change: 1 addition & 0 deletions Libraries/RCTRequired/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ fb_apple_library(
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
"talkios_link_group:xplat/default/public.react_native.infra",
],
)

0 comments on commit a885b1f

Please sign in to comment.