Skip to content

Commit

Permalink
Makes the Jobs required for Hermes to run in tagged build while relea…
Browse files Browse the repository at this point in the history
…sing (#39806)

Summary:
Pull Request resolved: #39806

Same issue of the previous fix: jobs do not run by default on tagged build. I forgot to add the filter parameter in the jobs that build the slices for Hermes and packages it and therefore the build failed.

I added those filters, so now we should be able to release RC.1.

What puzzles me is how it is possible that the publish-npm jobs even started, given that it was set up to depends on a job called build_hermes_macos which was not executed in the pipeline. 🤔

https://pxl.cl/3w2rr

## Changelog:
[Internal] - Make sure that the Hermes jobs starts when releasing

Reviewed By: dmytrorykun

Differential Revision: D49906898

fbshipit-source-id: ebbceb6cbc4dcd2ac22445610da1c52000c8ae2a
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Oct 4, 2023
1 parent 353d8d3 commit acb88d4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .circleci/configurations/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ workflows:
requires:
- prepare_hermes_workspace
- build_apple_slices_hermes:
filters: *only_release_tags
requires:
- build_hermesc_apple
matrix:
Expand All @@ -54,6 +55,7 @@ workflows:
requires:
- prepare_hermes_workspace
- build_hermes_macos:
filters: *only_release_tags
requires:
- build_apple_slices_hermes
matrix:
Expand Down

0 comments on commit acb88d4

Please sign in to comment.