Skip to content

Commit

Permalink
Fix a couple of warnings in the ReactAndroid:hermes-engine build
Browse files Browse the repository at this point in the history
Summary:
While buildling locally, those two warnings pop up.
- ANDROID_LD being unused by the CMake toolchain. I'm removing it.
- The Download task encountering a weak eTag. I'm updating it:
https://github.com/michel-kraemer/gradle-download-task

Changelog:
[Internal] [Changed] - Fix a couple of warnings in the ReactAndroid:hermes-engine build

Reviewed By: dmytrorykun

Differential Revision: D42738919

fbshipit-source-id: 7bd8785ad5b7431d557e2f8c8876b7c3f7294a43
  • Loading branch information
cortinico authored and facebook-github-bot committed Jan 25, 2023
1 parent 2bfb53c commit ae557a1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions ReactAndroid/hermes-engine/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ task downloadHermes(type: Download) {
src("https://github.com/facebook/hermes/tarball/${hermesVersion}")
onlyIfModified(true)
overwrite(true)
useETag(true)
useETag("all")
dest(new File(downloadsDir, "hermes.tar.gz"))
}

Expand Down Expand Up @@ -136,7 +136,6 @@ android {
arguments "-DHERMES_IS_ANDROID=True"
arguments "-DANDROID_STL=c++_shared"
arguments "-DANDROID_PIE=True"
arguments "-DANDROID_LD=lld"
arguments "-DIMPORT_HERMESC=${new File(hermesBuildDir, "ImportHermesc.cmake").toString()}"
arguments "-DJSI_DIR=${jsiDir}"
arguments "-DHERMES_SLOW_DEBUG=False"
Expand Down

0 comments on commit ae557a1

Please sign in to comment.