Skip to content

Commit

Permalink
Exclude dSYM from the archive
Browse files Browse the repository at this point in the history
Summary:
Currently, we are building the Debug symbols (dSYM) for hermes dSYM but we are not shipping them with the xcframework.
This is correct, because Debug symbols can increase the size of Hermes thus enalrging the iOS IPA and increasing the download time when installing pods.

We distribute the dSYM separatedly, in case users needs to symbolicate Hermes stack traces.

However the path to the dSYM still appears in the Info.plist of the universal XCFramework and this can cause issues when submitting an app to apple.

This change should remove those lines from the universal framework.

## Changelog
[Internal] - Remove dSYM path from Info.plist

Differential Revision: D62603425
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Sep 12, 2024
1 parent 3949d9b commit af11eb9
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -207,19 +207,19 @@ function create_universal_framework {
for i in "${!platforms[@]}"; do
local platform="${platforms[$i]}"
local hermes_framework_path="${platform}/hermes.framework"
local dSYM_path="$hermes_framework_path"
local dSYM_base_path="$HERMES_PATH/destroot/Library/Frameworks"
# local dSYM_path="$hermes_framework_path"
# local dSYM_base_path="$HERMES_PATH/destroot/Library/Frameworks"

# If the dSYM rename has failed, the dSYM are generated as 0.dSYM
# (Apple default name) rather then hermes.framework.dSYM.
if [[ -e "$dSYM_base_path/${platform}/0.dSYM" ]]; then
dSYM_path="${platform}/0"
fi
# if [[ -e "$dSYM_base_path/${platform}/0.dSYM" ]]; then
# dSYM_path="${platform}/0"
# fi

args+="-framework $hermes_framework_path "

# Path to dSYM must be absolute
args+="-debug-symbols $dSYM_base_path/$dSYM_path.dSYM "
# args+="-debug-symbols $dSYM_base_path/$dSYM_path.dSYM "
done

mkdir -p universal
Expand Down

0 comments on commit af11eb9

Please sign in to comment.