[Loader] Post a notification when the JS fails to load

Summary: This provides a way to get notified when a bridge fails to load JS, allowing apps to handle the error. Closes #1085 Github Author: James Ide <ide@jameside.com> Test Plan: run the UIExplorer app with the packager server not running, and verify that the notification is posted.
facebook · May 7, 2015 · b8bf4d0 · b8bf4d0
1 parent 205c22b
commit b8bf4d0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/React/Base/RCTBridge.h b/React/Base/RCTBridge.h
@@ -28,6 +28,11 @@ extern NSString *const RCTReloadNotification;
  */
 extern NSString *const RCTJavaScriptDidLoadNotification;
 
+/**
+ * This notification fires when the bridge failed to load.
+ */
+extern NSString *const RCTJavaScriptDidFailToLoadNotification;
+
 /**
  * This block can be used to instantiate modules that require additional
  * init parameters, or additional configuration prior to being used.

diff --git a/React/Base/RCTBridge.m b/React/Base/RCTBridge.m
@@ -31,6 +31,7 @@
 
 NSString *const RCTReloadNotification = @"RCTReloadNotification";
 NSString *const RCTJavaScriptDidLoadNotification = @"RCTJavaScriptDidLoadNotification";
+NSString *const RCTJavaScriptDidFailToLoadNotification = @"RCTJavaScriptDidFailToLoadNotification";
 
 dispatch_queue_t const RCTJSThread = nil;
 
@@ -1082,16 +1083,18 @@ - (void)initJS
 
     RCTJavaScriptLoader *loader = [[RCTJavaScriptLoader alloc] initWithBridge:self];
     [loader loadBundleAtURL:bundleURL onComplete:^(NSError *error, NSString *script) {
+
       _loading = NO;
       if (!self.isValid) {
         return;
       }
+
       RCTSourceCode *sourceCodeModule = self.modules[RCTBridgeModuleNameForClass([RCTSourceCode class])];
       sourceCodeModule.scriptURL = bundleURL;
       sourceCodeModule.scriptText = script;
-      if (error != nil) {
+      if (error) {
 
-        NSArray *stack = [[error userInfo] objectForKey:@"stack"];
+        NSArray *stack = [error userInfo][@"stack"];
         if (stack) {
           [[RCTRedBox sharedInstance] showErrorMessage:[error localizedDescription]
                                              withStack:stack];
@@ -1100,10 +1103,17 @@ - (void)initJS
                                            withDetails:[error localizedFailureReason]];
         }
 
+        NSDictionary *userInfo = @{@"error": error};
+        [[NSNotificationCenter defaultCenter] postNotificationName:RCTJavaScriptDidFailToLoadNotification
+                                                            object:self
+                                                          userInfo:userInfo];
+
       } else {
+
         [self enqueueApplicationScript:script url:bundleURL onComplete:^(NSError *loadError) {
 
           if (!loadError) {
+
             /**
              * Register the display link to start sending js calls after everything
              * is setup