android targetSdkVersion is 26 (#19944)

Summary: This PR sets gradle targetSdkVersion to 26, which will satisfy new requirements from Play Store. Also removed redundant config from manifest files. Closes #19944 Differential Revision: D8679682 Pulled By: hramos fbshipit-source-id: 5c900d47be1d8b81ce340e38a05d9b309da143c3
facebook · Jun 28, 2018 · bfb68c0 · bfb68c0
1 parent 6110a4c
commit bfb68c0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 13 deletions.
diff --git a/RNTester/android/app/build.gradle b/RNTester/android/app/build.gradle
@@ -90,7 +90,7 @@ android {
     defaultConfig {
         applicationId "com.facebook.react.uiapp"
         minSdkVersion 16
-        targetSdkVersion 23
+        targetSdkVersion 26
         versionCode 1
         versionName "1.0"
         ndk {

diff --git a/RNTester/android/app/src/main/AndroidManifest.xml b/RNTester/android/app/src/main/AndroidManifest.xml
@@ -1,9 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest
   xmlns:android="http://schemas.android.com/apk/res/android"
-  package="com.facebook.react.uiapp"
-  android:versionCode="1"
-  android:versionName="1.0">
+  package="com.facebook.react.uiapp">
 
   <uses-permission android:name="android.permission.INTERNET" />
   <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
@@ -16,10 +14,6 @@
   <uses-permission android:name="android.permission.CAMERA"/>
   <uses-permission android:name="android.permission.READ_CALENDAR"/>
 
-  <uses-sdk
-    android:minSdkVersion="16"
-    android:targetSdkVersion="23" />
-
   <!--
   android:icon is used to display launcher icon on mobile devices.
   android:banner is used to display a rectangular banned launcher icon on Android TV devices.

diff --git a/ReactAndroid/build.gradle b/ReactAndroid/build.gradle
@@ -250,7 +250,7 @@ android {
 
     defaultConfig {
         minSdkVersion 16
-        targetSdkVersion 22
+        targetSdkVersion 26
         versionCode 1
         versionName "1.0"
 

diff --git a/ReactAndroid/src/androidTest/AndroidManifest.xml b/ReactAndroid/src/androidTest/AndroidManifest.xml
@@ -1,9 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="com.facebook.react.tests.gradle"
-          android:versionCode="1"
-          android:versionName="1.0" >
-  <uses-sdk android:targetSdkVersion="7" />
+          package="com.facebook.react.tests.gradle">
   <supports-screens android:anyDensity="true" />
   <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />
   <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />