-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add a way to bind log function to the unified react native logger.
Summary: In this diff: 1. Convert the ReactNativeLogger to c function for the future compatibility. 2. Bind the log function from Catalyst app 3. Update the call site Changelog: [internal] Reviewed By: JoshuaGross Differential Revision: D30271863 fbshipit-source-id: 4c0ea704cf19f53468a3b72631353959ea999884
- Loading branch information
1 parent
3e5998e
commit c317a70
Showing
6 changed files
with
88 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
#include "react_native_log.h" | ||
#include <glog/logging.h> | ||
|
||
static reactnativelogfunctype _reactnativelogfunc = NULL; | ||
|
||
void set_react_native_logfunc(reactnativelogfunctype newlogfunc) { | ||
_reactnativelogfunc = newlogfunc; | ||
} | ||
void react_native_log_info(const char *message) { | ||
_react_native_log(ReactNativeLogLevelInfo, message); | ||
} | ||
void react_native_log_warn(const char *message) { | ||
_react_native_log(ReactNativeLogLevelWarning, message); | ||
} | ||
void react_native_log_error(const char *message) { | ||
_react_native_log(ReactNativeLogLevelError, message); | ||
} | ||
void react_native_log_fatal(const char *message) { | ||
_react_native_log(ReactNativeLogLevelFatal, message); | ||
} | ||
|
||
void _react_native_log(ReactNativeLogLevel level, const char *message) { | ||
if (_reactnativelogfunc == NULL) { | ||
_react_native_log_default(level, message); | ||
} else { | ||
_reactnativelogfunc(level, message); | ||
} | ||
} | ||
|
||
void _react_native_log_default(ReactNativeLogLevel level, const char *message) { | ||
switch (level) { | ||
case ReactNativeLogLevelInfo: | ||
LOG(INFO) << message; | ||
break; | ||
case ReactNativeLogLevelWarning: | ||
LOG(WARNING) << message; | ||
break; | ||
case ReactNativeLogLevelError: | ||
LOG(ERROR) << message; | ||
break; | ||
case ReactNativeLogLevelFatal: | ||
LOG(FATAL) << message; | ||
break; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
#pragma once | ||
|
||
enum ReactNativeLogLevel { | ||
ReactNativeLogLevelInfo = 1, | ||
ReactNativeLogLevelWarning = 2, | ||
ReactNativeLogLevelError = 3, | ||
ReactNativeLogLevelFatal = 4 | ||
}; | ||
|
||
typedef void (*reactnativelogfunctype)(ReactNativeLogLevel, const char *); | ||
|
||
#ifdef __cplusplus | ||
extern "C" { | ||
#endif // __cplusplus | ||
void set_react_native_logfunc(reactnativelogfunctype newlogfunc); | ||
|
||
void react_native_log_info(const char *text); | ||
void react_native_log_warn(const char *text); | ||
void react_native_log_error(const char *text); | ||
void react_native_log_fatal(const char *text); | ||
|
||
void _react_native_log(ReactNativeLogLevel level, const char *text); | ||
void _react_native_log_default(ReactNativeLogLevel level, const char *text); | ||
#ifdef __cplusplus | ||
} | ||
#endif // __cpusplus |