-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Import OCMock as a pod for RNTester on iOS (#36239)
Summary: This is a change we have implemented in React Native macOS that I am now upstreaming: microsoft#1257 The library `ocMock` is currently imported as a checked in binary by RN-Tester to help run unit tests on iOS. That binary is only compiled for x86 on macOS, which meant we could not run tests on M1 / M2 Macs. Switching it so that we import from source as a pod should make maintenance easier for both iOS and macOS! :) Original change notes: >Previously, we've been unable to test RNTester for macOS on an M1 machine. This is because we were using a framework that was prebuilt for Intel architecture, so the test components would fail to build. > > The fix is to build OCMock from source directly instead of using a prebuilt version. > > This is only necessary on macOS. The iOS version is already built for ARM architecture, as iOS devices have been running exclusively on ARM for a while now. ## Changelog [INTERNAL] [CHANGED] - Import OCMock as a pod Pull Request resolved: #36239 Test Plan: CI should pass as it did before. Reviewed By: dmytrorykun Differential Revision: D43732219 Pulled By: cipolleschi fbshipit-source-id: 028b5a7f384042145bf1966c8c2730d7437940ec
- Loading branch information
1 parent
350c055
commit d00c150
Showing
12 changed files
with
7 additions
and
451 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 0 additions & 27 deletions
27
packages/rn-tester/RNTesterUnitTests/OCMock/NSNotificationCenter+OCMAdditions.h
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
65 changes: 0 additions & 65 deletions
65
packages/rn-tester/RNTesterUnitTests/OCMock/OCMConstraint.h
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
43 changes: 0 additions & 43 deletions
43
packages/rn-tester/RNTesterUnitTests/OCMock/OCMMacroState.h
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
55 changes: 0 additions & 55 deletions
55
packages/rn-tester/RNTesterUnitTests/OCMock/OCMStubRecorder.h
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.