Skip to content

Commit

Permalink
Fix [Windows]: Rename utils/jsi files (#43700)
Browse files Browse the repository at this point in the history
Summary:
This PR: https://github.com/facebook/react-native/pull/42801/files#diff-ff466c93fb60f2b0e79ed187f492c9935349a2b2f2a7300b310e2bb30e31c33e creates a new jsi.h and jsi.cpp file in ReactCommon. On windows, even though the files have different paths, MSVC doesn't allow two files to have the same name in the same project. This PR changes the name of the new jsi.h and jsi.cpp files.

## Changelog:

[General][Fixed] - Rename utils/jsi files

Pull Request resolved: #43700

Test Plan: tested on windows

Reviewed By: zeyap

Differential Revision: D55491700

Pulled By: arushikesarwani94

fbshipit-source-id: 2995c0602a9528ed0f8e8eb2230945cb6bd516e9
  • Loading branch information
TatianaKapos authored and facebook-github-bot committed Mar 29, 2024
1 parent f7ec469 commit d0cac87
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "TurboModuleBinding.h"

#include <cxxreact/SystraceSection.h>
#include <react/utils/jsi.h>
#include <react/utils/jsi-utils.h>
#include <stdexcept>
#include <string>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include <jsireact/JSIExecutor.h>
#include <react/featureflags/ReactNativeFeatureFlags.h>
#include <react/renderer/runtimescheduler/RuntimeSchedulerBinding.h>
#include <react/utils/jsi.h>
#include <react/utils/jsi-utils.h>
#include <iostream>
#include <memory>
#include <tuple>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/

#include "jsi.h"
#include "jsi-utils.h"

namespace facebook::react {

Expand Down

0 comments on commit d0cac87

Please sign in to comment.