Skip to content

Commit

Permalink
Update description about jsBundleURLForBundleRoot method (#39265)
Browse files Browse the repository at this point in the history
Summary:
Update comment in RCTBundleURLProvider.h to use correct `jsBundleURLForBundleRoot` import with `fallbackExtension` instead `fallbackResource`

## Changelog:

- Update comment in `jsBundleURLForBundleRoot` definition on RCTBundleURLProvider.h file.

Pick one each for the category and type tags:

[IOS][CHANGED] - Updated comment in RCTBundleURLProvider.h to instance correct jsBundleURLForBundleRoot:fallbackExtension method.

Pull Request resolved: #39265

Test Plan: N/A

Reviewed By: cortinico

Differential Revision: D49227104

Pulled By: GijsWeterings

fbshipit-source-id: 6ccfb984ab6c1e858f1c568b2dd8f4626e133ffb
  • Loading branch information
JulioCVaz authored and facebook-github-bot committed Sep 15, 2023
1 parent a931867 commit d208dc4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-native/React/Base/RCTBundleURLProvider.h
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ RCT_EXTERN void RCTBundleURLProviderAllowPackagerServerAccess(BOOL allowed);

/**
* Given a hostname for the packager and a bundle root, returns the URL to the js bundle. Generally you should use the
* instance method -jsBundleURLForBundleRoot:fallbackResource: which includes logic to guess if the packager is running
* instance method -jsBundleURLForBundleRoot:fallbackExtension: which includes logic to guess if the packager is running
* and fall back to a pre-packaged bundle if it is not.
*
* The options here mirror some of Metro's Bundling Options:
Expand Down

0 comments on commit d208dc4

Please sign in to comment.