Skip to content

Commit

Permalink
Remove JSCJavaScriptExecutor/Factory (#41406)
Browse files Browse the repository at this point in the history
Summary:
- `JSCJavaScriptExecutor` & `JSCJavaScriptExecutorFactory` have been deprecated according to #38594
- `JSCJavaScriptExecutor`'s native implementation is missing
- `JSCJavaScriptExecutor` should be bundle into library that contains `JSCJavaScriptExecutorHolder`, e.g. [`V8Executor`](https://github.com/Sunbreak/react-native/blob/0.69-v8/ReactAndroid/src/main/java/io/csie/kudo/reactnative/v8/executor/V8Executor.java) and [`V8ExecutorHolder`](https://github.com/Sunbreak/react-native/blob/0.69-v8/ReactAndroid/src/main/java/com/facebook/v8/executor/OnLoad.cpp)

```mermaid
classDiagram
    class JSCJavaScriptExecutor["JSCJavaScriptExecutor.java"] {
        -initHybrid()$
    }
    class JSCExecutor["JSCExecutor.java"] {
        -initHybrid()$
    }
    JSCExecutor <|.. JSCExecutorHolder: Composition
    class JSCExecutorHolder["JSCExecutorHolder.cpp"] {
        +initHybrid()$
    }
    class HermesExecutor["HermesExecutor.java"] {
        -initHybrid()$
    }
    HermesExecutor <|.. HermesExecutorHolder: Composition
    class HermesExecutorHolder["HermesExecutor.cpp"] {
        +initHybrid()$
    }
    class ProxyJavaScriptExecutor["ProxyJavaScriptExecutor.java"] {
        -initHybrid()$
    }
    ProxyJavaScriptExecutor <|.. ProxyJavaScriptExecutorHolder: Composition
    class ProxyJavaScriptExecutorHolder["ProxyJavaScriptExecutorHolder.cpp"] {
        +initHybrid()$
    }
```

Remove JSCJavaScriptExecutor/Factory

## Changelog:

[ANDROID] [REMOVED] - Remove JSCJavaScriptExecutor/Factory

Pull Request resolved: #41406

Test Plan: None

Reviewed By: christophpurrer

Differential Revision: D51198037

Pulled By: javache

fbshipit-source-id: 73f335f76adfe644bef1ee37e8ec474625d37e0d
  • Loading branch information
Sunbreak authored and facebook-github-bot committed Nov 13, 2023
1 parent 99ebcfd commit d7fd83e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 77 deletions.

This file was deleted.

This file was deleted.

0 comments on commit d7fd83e

Please sign in to comment.