fix lint errors

Summary: Changelog: [Internal][Yoga] Fixed lint errors ```arc lint --apply-patches --take CLANGFORMAT --paths-cmd 'hg files xplat/yoga' ``` Added .clang-tidy file Reviewed By: zertosh Differential Revision: D19948702 fbshipit-source-id: f77a16d6f2c532267597a84a9caded0aae68c3aa
facebook · Feb 18, 2020 · d8ff5a5 · d8ff5a5
1 parent 96f19a3
commit d8ff5a5
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 16 deletions.
diff --git a/ReactAndroid/src/main/jni/first-party/yogajni/.clang-tidy b/ReactAndroid/src/main/jni/first-party/yogajni/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactAndroid/src/main/jni/first-party/yogajni/jni/ScopedGlobalRef.h b/ReactAndroid/src/main/jni/first-party/yogajni/jni/ScopedGlobalRef.h
@@ -84,9 +84,7 @@ class ScopedGlobalRef {
     return *this;
   }
 
-  ~ScopedGlobalRef() {
-    reset();
-  }
+  ~ScopedGlobalRef() { reset(); }
 
   /**
    * Deletes the currently held reference and reassigns a new one to the
@@ -120,9 +118,7 @@ class ScopedGlobalRef {
   /**
    * Returns true if the underlying JNI reference is not NULL.
    */
-  operator bool() const {
-    return mGlobalRef != NULL;
-  }
+  operator bool() const { return mGlobalRef != NULL; }
 
   ScopedGlobalRef(const ScopedGlobalRef& ref) = delete;
   ScopedGlobalRef& operator=(const ScopedGlobalRef& other) = delete;

diff --git a/ReactAndroid/src/main/jni/first-party/yogajni/jni/ScopedLocalRef.h b/ReactAndroid/src/main/jni/first-party/yogajni/jni/ScopedLocalRef.h
@@ -83,9 +83,7 @@ class ScopedLocalRef {
     return *this;
   }
 
-  ~ScopedLocalRef() {
-    reset();
-  }
+  ~ScopedLocalRef() { reset(); }
 
   /**
    * Deletes the currently held reference and reassigns a new one to the
@@ -119,9 +117,7 @@ class ScopedLocalRef {
   /**
    * Returns true if the underlying JNI reference is not NULL.
    */
-  operator bool() const {
-    return mLocalRef != NULL;
-  }
+  operator bool() const { return mLocalRef != NULL; }
 
   ScopedLocalRef(const ScopedLocalRef& ref) = delete;
   ScopedLocalRef& operator=(const ScopedLocalRef& other) = delete;

diff --git a/ReactAndroid/src/main/jni/first-party/yogajni/jni/common.cpp b/ReactAndroid/src/main/jni/first-party/yogajni/jni/common.cpp
@@ -77,8 +77,11 @@ DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(void, Void) {
   assertNoPendingJniException(env);
 }
 
-ScopedLocalRef<jobject>
-callStaticObjectMethod(JNIEnv* env, jclass clazz, jmethodID methodId, ...) {
+ScopedLocalRef<jobject> callStaticObjectMethod(
+    JNIEnv* env,
+    jclass clazz,
+    jmethodID methodId,
+    ...) {
   va_list args;
   va_start(args, methodId);
   jobject result = env->CallStaticObjectMethodV(clazz, methodId, args);

diff --git a/ReactAndroid/src/main/jni/first-party/yogajni/jni/common.h b/ReactAndroid/src/main/jni/first-party/yogajni/jni/common.h
@@ -61,8 +61,11 @@ DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(void, Void);
 DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(jlong, Long);
 DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(jfloat, Float);
 
-ScopedLocalRef<jobject>
-callStaticObjectMethod(JNIEnv* env, jclass clazz, jmethodID methodId, ...);
+ScopedLocalRef<jobject> callStaticObjectMethod(
+    JNIEnv* env,
+    jclass clazz,
+    jmethodID methodId,
+    ...);
 
 /**
  * Given a local or a global reference, this method creates a new global