-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add @types/react as optional peerDependency on packages that use it (#…
…43509) Summary: Now that RN is providing TS type information, many of those .d.ts files depend on types from react. In modern packagemanagers (Ex: pnpm) types/react will not be available to RN since it does not declare it as a dependency. I also noticed that the types for react-native-popup-menu-android appear to be pointing to the wrong location. Add types/react as a peerDependency on the packages that have .d.ts files that import from React. Add types/react to peerDependencyMeta with optional:true to prevent users not using TS from requiring types/react. ## Changelog: [GENERAL] [ADDED] Added types/react as an optional peerDependency Pull Request resolved: #43509 Reviewed By: cortinico Differential Revision: D55225940 Pulled By: NickGerleman fbshipit-source-id: 4cbab071928cb925baec45f55461559acc9a54e6
- Loading branch information
1 parent
8a2cf68
commit dbf8e3f
Showing
6 changed files
with
26 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters