Skip to content

Commit

Permalink
Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release (#…
Browse files Browse the repository at this point in the history
…38212)

Summary:
Pull Request resolved: #38212

This mirrors the same logic that the Hermes team has on facebook/hermes.
Practically, we want to pass the CMake config flag `HERMES_ENABLE_DEBUGGER=False` only for Release
so that their CMake build is configured correctly.

Their build always enables the Debugger and allows us to selectively turn it off only for release
builds.

More context: facebook/hermes@eabf5fcd25

Changelog:
[Internal] [Changed] - Compile hermes-engine with -DHERMES_ENABLE_DEBUGGER=False on Release

Reviewed By: cipolleschi

Differential Revision: D47252735

fbshipit-source-id: 8096c8389a045ac0c56ace20ea3be2c1fa03603f
  • Loading branch information
cortinico authored and facebook-github-bot committed Jul 6, 2023
1 parent 41477c8 commit dc0192e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/react-native/ReactAndroid/hermes-engine/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ android {
externalNativeBuild {
cmake {
arguments "-DCMAKE_BUILD_TYPE=MinSizeRel"
// For release builds, we don't want to enable the Hermes Debugger.
arguments "-DHERMES_ENABLE_DEBUGGER=False"
}
}
}
Expand Down

0 comments on commit dc0192e

Please sign in to comment.