Skip to content

Commit

Permalink
Remove support for Android API < 23 in ReactTextInputShadowNode (#39686)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #39686

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextInputShadowNode

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextInputShadowNode

Reviewed By: NickGerleman

Differential Revision: D48545503

fbshipit-source-id: f3b4fb696c3abf1f20ab00a89e786b3787c1b0e9
  • Loading branch information
mdvacca authored and facebook-github-bot committed Sep 29, 2023
1 parent b968cb6 commit dc3fc16
Showing 1 changed file with 2 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

package com.facebook.react.views.textinput;

import android.annotation.TargetApi;
import android.os.Build;
import android.text.Layout;
import android.util.TypedValue;
import android.view.ViewGroup;
Expand All @@ -35,7 +33,6 @@
import com.facebook.yoga.YogaNode;

@VisibleForTesting
@TargetApi(Build.VERSION_CODES.M)
public class ReactTextInputShadowNode extends ReactBaseTextShadowNode
implements YogaMeasureFunction {

Expand All @@ -53,10 +50,7 @@ public class ReactTextInputShadowNode extends ReactBaseTextShadowNode
public ReactTextInputShadowNode(
@Nullable ReactTextViewManagerCallback reactTextViewManagerCallback) {
super(reactTextViewManagerCallback);
mTextBreakStrategy =
(Build.VERSION.SDK_INT < Build.VERSION_CODES.M)
? Layout.BREAK_STRATEGY_SIMPLE
: Layout.BREAK_STRATEGY_HIGH_QUALITY;
mTextBreakStrategy = Layout.BREAK_STRATEGY_HIGH_QUALITY;

initMeasureFunction();
}
Expand Down Expand Up @@ -118,8 +112,7 @@ public long measure(
editText.setLines(mNumberOfLines);
}

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M
&& editText.getBreakStrategy() != mTextBreakStrategy) {
if (editText.getBreakStrategy() != mTextBreakStrategy) {
editText.setBreakStrategy(mTextBreakStrategy);
}
}
Expand Down Expand Up @@ -182,10 +175,6 @@ public void setPlaceholder(@Nullable String placeholder) {

@Override
public void setTextBreakStrategy(@Nullable String textBreakStrategy) {
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
return;
}

if (textBreakStrategy == null || "simple".equals(textBreakStrategy)) {
mTextBreakStrategy = Layout.BREAK_STRATEGY_SIMPLE;
} else if ("highQuality".equals(textBreakStrategy)) {
Expand Down

0 comments on commit dc3fc16

Please sign in to comment.