Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RNTester-ios / RCTAppDelegate > correctly check for USE_HERMES Flag (#…
…41573) Summary: Pull Request resolved: #41573 Changelog: [iOS][Fixed] RNTester-ios / RCTAppDelegate > correctly check for USE_HERMES Flag On iOS we check for ENV flags if Hermes should be used: - https://github.com/facebook/react-native/blob/b4d4aef057ebf90176287f22d72b4b3b8b280c9a/packages/react-native/React-Core.podspec#L24 - https://github.com/facebook/react-native/blob/b4d4aef057ebf90176287f22d72b4b3b8b280c9a/packages/react-native/React/React-RCTFabric.podspec#L90 and add necessary C++ packages based on that flag. In code we do check for those imports https://github.com/facebook/react-native/blob/b4d4aef057ebf90176287f22d72b4b3b8b280c9a/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.h#L16-L27 and decided if we should use Hermes or not. However the .mm check is faulty and does not check for the `RCT_USE_HERMES` flag set in code. Reviewed By: fkgozali Differential Revision: D51483740 fbshipit-source-id: 428c27aae80fe6f9799cf6ae21a5d3801fe6ca11
- Loading branch information