[Resolve]

facebook · Sep 12, 2017 · e3688b5 · e3688b5
2 parents 7560ce0 + b45c91d
commit e3688b5
Show file tree

Hide file tree

Showing 522 changed files with 10,874 additions and 6,462 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -64,7 +64,17 @@
 
   // General
 
-    "comma-dangle": 0,               // disallow trailing commas in object literals
+    // This must be disallowed in this repo because the minimum supported
+    // version of node is 4 which doesn't support trailing commas.
+    // Once the minimum supported version is 8 or greater this can be changed
+    "comma-dangle": [2, {            // disallow trailing commas in object literals
+        "arrays": "ignore",
+        "objects": "ignore",
+        "imports": "ignore",
+        "exports": "ignore",
+        "functions": "never"
+    }],
+
     "no-cond-assign": 1,             // disallow assignment in conditional expressions
     "no-console": 0,                 // disallow use of console (off by default in the node environment)
     "no-const-assign": 2,            // disallow assignment to const-declared variables

diff --git a/.flowconfig b/.flowconfig
@@ -42,14 +42,16 @@ module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|we
 
 suppress_type=$FlowIssue
 suppress_type=$FlowFixMe
+suppress_type=$FlowFixMeProps
+suppress_type=$FlowFixMeState
 suppress_type=$FixMe
 
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-2]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-2]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-4]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-4]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
 suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
 
 unsafe.enable_getters_and_setters=true
 
 [version]
-^0.52.0
+^0.54.0
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1,20 +1,18 @@
-docs/* @facebook/react-native
-blog/* @facebook/react-native
+docs/* @hramos
+blog/* @hramos
 Libraries/Animated/* @janicduplessis
 Libraries/NativeAnimation/* @janicduplessis
 Libraries/Image/* @shergin
 Libraries/Text/* @shergin
-React/Base/* @shergin @javache
-React/Views/* @shergin @javache
-React/Modules/* @shergin @javache
-React/CxxBridge/* @javache
-React/Executors/* @javache
+React/Base/* @shergin
+React/Views/* @shergin
+React/Modules/* @shergin
+React/CxxBridge/* @mhorowitz
 ReactAndroid/src/main/java/com/facebook/react/animated/* @janicduplessis
-ReactCommon/* @javache
-website/* @facebook/react-native
-website/showcase.json @facebook/react-native
-package.json @facebook/react-native
-website/package.json @facebook/react-native
+website/* @hramos
+website/showcase.json @hramos
+package.json @hramos
+website/package.json @hramos
 local-cli/core/* @grabbou @kureev
 local-cli/link/* @grabbou @kureev
 local-cli/unlink/* @grabbou @kureev
diff --git a/IntegrationTests/AccessibilityManagerTest.js b/IntegrationTests/AccessibilityManagerTest.js
@@ -21,7 +21,7 @@ const {
 } = ReactNative.NativeModules;
 
 
-class AccessibilityManagerTest extends React.Component {
+class AccessibilityManagerTest extends React.Component<{}> {
   componentDidMount() {
     AccessibilityManager.setAccessibilityContentSizeMultipliers({
       'extraSmall': 1.0,
@@ -42,7 +42,7 @@ class AccessibilityManagerTest extends React.Component {
     });
   }
 
-  render(): React.Element<any> {
+  render(): React.Node {
     return <View />;
   }
 }

diff --git a/IntegrationTests/AppEventsTest.js b/IntegrationTests/AppEventsTest.js
@@ -32,7 +32,7 @@ type State = {
   elapsed?: string,
 };
 
-class AppEventsTest extends React.Component {
+class AppEventsTest extends React.Component<{}, State> {
   state: State = {sent: 'none', received: 'none'};
 
   componentDidMount() {

diff --git a/IntegrationTests/AsyncStorageTest.js b/IntegrationTests/AsyncStorageTest.js
@@ -168,7 +168,7 @@ function testOptimizedMultiGet() {
 }
 
 
-class AsyncStorageTest extends React.Component {
+class AsyncStorageTest extends React.Component<{}, $FlowFixMeState> {
   state = {
     messages: 'Initializing...',
     done: false,
@@ -189,7 +189,11 @@ class AsyncStorageTest extends React.Component {
     return (
       <View style={{backgroundColor: 'white', padding: 40}}>
         <Text>
-          {this.constructor.displayName + ': '}
+          {
+            /* $FlowFixMe(>=0.54.0 site=react_native_fb,react_native_oss) This
+             * comment suppresses an error found when Flow v0.54 was deployed.
+             * To see the error delete this comment and run Flow. */
+            this.constructor.displayName + ': '}
           {this.state.done ? 'Done' : 'Testing...'}
           {'\n\n' + this.state.messages}
         </Text>

diff --git a/IntegrationTests/ImageCachePolicyTest.js b/IntegrationTests/ImageCachePolicyTest.js
@@ -41,7 +41,7 @@ type State = {
   'force-cache'?: boolean,
 }
 
-class ImageCachePolicyTest extends React.Component {
+class ImageCachePolicyTest extends React.Component<Props, $FlowFixMeState> {
   state = {}
 
   shouldComponentUpdate(nextProps: Props, nextState: State) {

diff --git a/IntegrationTests/ImageSnapshotTest.js b/IntegrationTests/ImageSnapshotTest.js
@@ -19,7 +19,7 @@ var {
 } = ReactNative;
 var { TestModule } = ReactNative.NativeModules;
 
-class ImageSnapshotTest extends React.Component {
+class ImageSnapshotTest extends React.Component<{}> {
   componentDidMount() {
     if (!TestModule.verifySnapshot) {
       throw new Error('TestModule.verifySnapshot not defined.');

diff --git a/IntegrationTests/IntegrationTestHarnessTest.js b/IntegrationTests/IntegrationTestHarnessTest.js
@@ -11,6 +11,9 @@
  */
 'use strict';
 
+/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
+ * found when Flow v0.54 was deployed. To see the error delete this comment and
+ * run Flow. */
 var requestAnimationFrame = require('fbjs/lib/requestAnimationFrame');
 var React = require('react');
 var PropTypes = require('prop-types');
@@ -21,12 +24,10 @@ var {
 } = ReactNative;
 var { TestModule } = ReactNative.NativeModules;
 
-class IntegrationTestHarnessTest extends React.Component {
-  props: {
-    shouldThrow?: boolean,
-    waitOneFrame?: boolean,
-  };
-
+class IntegrationTestHarnessTest extends React.Component<{
+  shouldThrow?: boolean,
+  waitOneFrame?: boolean,
+}, $FlowFixMeState> {
   static propTypes = {
     shouldThrow: PropTypes.bool,
     waitOneFrame: PropTypes.bool,
@@ -62,7 +63,11 @@ class IntegrationTestHarnessTest extends React.Component {
     return (
       <View style={{backgroundColor: 'white', padding: 40}}>
         <Text>
-          {this.constructor.displayName + ': '}
+          {
+            /* $FlowFixMe(>=0.54.0 site=react_native_fb,react_native_oss) This
+             * comment suppresses an error found when Flow v0.54 was deployed.
+             * To see the error delete this comment and run Flow. */
+            this.constructor.displayName + ': '}
           {this.state.done ? 'Done' : 'Testing...'}
         </Text>
       </View>

diff --git a/IntegrationTests/IntegrationTestsApp.js b/IntegrationTests/IntegrationTestsApp.js
@@ -40,6 +40,9 @@ var TESTS = [
 ];
 
 TESTS.forEach(
+  /* $FlowFixMe(>=0.54.0 site=react_native_fb,react_native_oss) This comment
+   * suppresses an error found when Flow v0.54 was deployed. To see the error
+   * delete this comment and run Flow. */
   (test) => AppRegistry.registerComponent(test.displayName, () => test)
 );
 
@@ -48,7 +51,7 @@ require('LoggingTestModule');
 
 type Test = any;
 
-class IntegrationTestsApp extends React.Component {
+class IntegrationTestsApp extends React.Component<{}, $FlowFixMeState> {
   state = {
     test: (null: ?Test),
   };
@@ -57,6 +60,9 @@ class IntegrationTestsApp extends React.Component {
     if (this.state.test) {
       return (
         <ScrollView>
+          {/* $FlowFixMe(>=0.53.0 site=react_native_fb,react_native_oss) This
+            * comment suppresses an error when upgrading Flow's support for
+            * React. To see the error delete this comment and run Flow. */}
           <this.state.test />
         </ScrollView>
       );

diff --git a/IntegrationTests/PromiseTest.js b/IntegrationTests/PromiseTest.js
@@ -16,7 +16,7 @@ var ReactNative = require('react-native');
 var { View } = ReactNative;
 var { TestModule } = ReactNative.NativeModules;
 
-class PromiseTest extends React.Component {
+class PromiseTest extends React.Component<{}> {
   shouldResolve = false;
   shouldReject = false;
   shouldSucceedAsync = false;
@@ -66,7 +66,7 @@ class PromiseTest extends React.Component {
     }
   };
 
-  render(): React.Element<any> {
+  render(): React.Node {
     return <View />;
   }
 }

diff --git a/IntegrationTests/SimpleSnapshotTest.js b/IntegrationTests/SimpleSnapshotTest.js
@@ -13,6 +13,9 @@
 
 var React = require('react');
 var ReactNative = require('react-native');
+/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
+ * found when Flow v0.54 was deployed. To see the error delete this comment and
+ * run Flow. */
 var requestAnimationFrame = require('fbjs/lib/requestAnimationFrame');
 
 var {
@@ -21,7 +24,7 @@ var {
 } = ReactNative;
 var { TestModule } = ReactNative.NativeModules;
 
-class SimpleSnapshotTest extends React.Component {
+class SimpleSnapshotTest extends React.Component<{}> {
   componentDidMount() {
     if (!TestModule.verifySnapshot) {
       throw new Error('TestModule.verifySnapshot not defined.');

diff --git a/IntegrationTests/SyncMethodTest.js b/IntegrationTests/SyncMethodTest.js
@@ -21,7 +21,7 @@ const {
 } = ReactNative.NativeModules;
 
 
-class SyncMethodTest extends React.Component {
+class SyncMethodTest extends React.Component<{}> {
   componentDidMount() {
     if (RNTesterTestModule.echoString('test string value') !== 'test string value') {
       throw new Error('Something wrong with sync method export');
@@ -32,7 +32,7 @@ class SyncMethodTest extends React.Component {
     TestModule.markTestCompleted();
   }
 
-  render(): React.Element<any> {
+  render(): React.Node {
     return <View />;
   }
 }

diff --git a/IntegrationTests/TimersTest.js b/IntegrationTests/TimersTest.js
@@ -14,6 +14,9 @@
 var React = require('react');
 var createReactClass = require('create-react-class');
 var ReactNative = require('react-native');
+/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
+ * found when Flow v0.54 was deployed. To see the error delete this comment and
+ * run Flow. */
 var TimerMixin = require('react-timer-mixin');
 
 var {

diff --git a/IntegrationTests/WebSocketTest.js b/IntegrationTests/WebSocketTest.js
@@ -42,7 +42,7 @@ type State = {
   testExpectedResponse: string;
 };
 
-class WebSocketTest extends React.Component {
+class WebSocketTest extends React.Component<{}, State> {
   state: State = {
     url: DEFAULT_WS_URL,
     fetchStatus: null,
@@ -158,7 +158,7 @@ class WebSocketTest extends React.Component {
     });
   }
 
-  render(): React.Element<any> {
+  render(): React.Node {
     return <View />;
   }
 }

diff --git a/IntegrationTests/WebViewTest.js b/IntegrationTests/WebViewTest.js
@@ -5,6 +5,8 @@
  * This source code is licensed under the BSD-style license found in the
  * LICENSE file in the root directory of this source tree. An additional grant
  * of patent rights can be found in the PATENTS file in the same directory.
+ *
+ * @providesModule WebViewTest
  */
 'use strict';
 

diff --git a/IntegrationTests/websocket_integration_test_server.js b/IntegrationTests/websocket_integration_test_server.js
@@ -15,6 +15,9 @@
 
 /* eslint-env node */
 
+/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
+ * found when Flow v0.54 was deployed. To see the error delete this comment and
+ * run Flow. */
 const WebSocket = require('ws');
 
 console.log(`\

diff --git a/Libraries/.eslintrc b/Libraries/.eslintrc
@@ -0,0 +1,7 @@
+{
+  "rules": {
+    // This folder currently runs through babel and doesn't need to be
+    // compatible with node 4
+    "comma-dangle": 0
+  }
+}
diff --git a/Libraries/Alert/AlertIOS.js b/Libraries/Alert/AlertIOS.js
@@ -109,7 +109,7 @@ class AlertIOS {
    * Create and display a popup alert.
    * @static
    * @method alert
-   * @param title The dialog's title.
+   * @param title The dialog's title. Passing null or '' will hide the title.
    * @param message An optional message that appears below
    *     the dialog's title.
    * @param callbackOrButtons This optional argument should
@@ -209,7 +209,7 @@ class AlertIOS {
       var callback = type;
       var defaultValue = message;
       RCTAlertManager.alertWithArgs({
-        title: title || undefined,
+        title: title || '',
         type: 'plain-text',
         defaultValue,
       }, (id, value) => {
@@ -242,7 +242,7 @@ class AlertIOS {
     }
 
     RCTAlertManager.alertWithArgs({
-      title: title || undefined,
+      title: title || '',
       message: message || undefined,
       buttons,
       type: type || undefined,