Skip to content

Commit

Permalink
Bugfix: Check NodeJS version successfully even for old runtimes (Fixes
Browse files Browse the repository at this point in the history
…#20769) (#20779)

Summary:
Fixes #20769

Release notes
--------------
[CLI] [BUGFIX] [local-cli/server/checkNodeVersion.js] - Disable auto-formatting in `local-cli/server/checkNodeVersion.js` since it introduces ES6 and ES7 syntax (trailing comma in argument list) which in turn makes ES5 engines crash with a `SyntaxError`.
Pull Request resolved: #20779

Differential Revision: D9468346

Pulled By: hramos

fbshipit-source-id: 24761a377a5fd104e11ed6b6e86da15e96a0e38b
  • Loading branch information
Elias Toivanen authored and facebook-github-bot committed Aug 23, 2018
1 parent 9a77ff5 commit e61176d
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions local-cli/server/checkNodeVersion.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
* Be mindful that this script may be run by legacy NodeJS runtimes. Keep this
* script ES5 compatible (e.g. do not insert the `@format` pragma here which
* may introduce non-ES5 compatible syntax.)
*
*/

'use strict';
Expand Down Expand Up @@ -36,7 +39,7 @@ module.exports = function() {
marginLeft: 1,
marginRight: 1,
paddingBottom: 1,
}),
})
);
process.exit(1);
}
Expand Down

0 comments on commit e61176d

Please sign in to comment.