Fix events not working after closing and navigating back to Fabric sc…

…reen in FB4A Reviewed By: fkgozali Differential Revision: D8240344 fbshipit-source-id: 992945f94843589cefdf7ea24da709449ee38778
facebook · Jun 5, 2018 · e95e73a · e95e73a
1 parent de18dd2
commit e95e73a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 15 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
@@ -66,6 +66,7 @@ public class FabricUIManager implements UIManager, JSHandler {
   private final FabricReconciler mFabricReconciler;
   private final EventDispatcher mEventDispatcher;
   private FabricBinding mBinding;
+  private final FabricEventEmitter mFabricEventEmitter;
   private long mEventHandlerPointer;
 
   public FabricUIManager(
@@ -81,6 +82,8 @@ public FabricUIManager(
         new UIViewOperationQueue(
             reactContext, mNativeViewHierarchyManager, 0);
     mFabricReconciler = new FabricReconciler(mUIViewOperationQueue);
+    mFabricEventEmitter =
+      new FabricEventEmitter(mReactApplicationContext, this);
     mEventDispatcher = eventDispatcher;
     mJSContext = jsContext;
   }
@@ -537,12 +540,14 @@ public void invoke(long eventTarget, String name, WritableMap params) {
   public void initialize() {
     FabricEventEmitter eventEmitter =
       new FabricEventEmitter(mReactApplicationContext, this);
-    mEventDispatcher.registerEventEmitter(FABRIC, eventEmitter);
+    mEventDispatcher.registerEventEmitter(FABRIC, mFabricEventEmitter);
   }
 
   @Override
   public void onCatalystInstanceDestroy() {
     mBinding.releaseEventHandler(mJSContext.get(), mEventHandlerPointer);
+    mEventDispatcher.unregisterEventEmitter(FABRIC);
+    mFabricEventEmitter.close();
   }
 
 }
diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/EventDispatcher.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/EventDispatcher.java
@@ -161,7 +161,6 @@ public void onHostPause() {
   @Override
   public void onHostDestroy() {
     stopFrameCallback();
-    mReactEventEmitter.stop();
   }
 
   public void onCatalystInstanceDestroyed() {
@@ -254,6 +253,10 @@ public void registerEventEmitter(@UIManagerType int uiManagerType, RCTEventEmitt
     mReactEventEmitter.register(uiManagerType, eventEmitter);
   }
 
+  public void unregisterEventEmitter(@UIManagerType int uiManagerType) {
+    mReactEventEmitter.unregister(uiManagerType);
+  }
+
   private class ScheduleDispatchFrameCallback extends ChoreographerCompat.FrameCallback {
     private volatile boolean mIsPosted = false;
     private boolean mShouldStop = false;

diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/ReactEventEmitter.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/ReactEventEmitter.java
@@ -31,6 +31,10 @@ public void register(@UIManagerType int uiManagerType, RCTEventEmitter eventEmit
     mEventEmitters.put(uiManagerType, eventEmitter);
   }
 
+  public void unregister(@UIManagerType int uiManagerType) {
+    mEventEmitters.remove(uiManagerType);
+  }
+
   @Override
   public void receiveEvent(int targetReactTag, String eventName, @Nullable WritableMap event) {
     getEventEmitter(targetReactTag).receiveEvent(targetReactTag, eventName, event);
@@ -52,17 +56,4 @@ private RCTEventEmitter getEventEmitter(int reactTag) {
     int type = ViewUtil.getUIManagerType(reactTag);
     return mEventEmitters.get(type);
   }
-
-  public void stop() {
-    for (int i = 0 ; i < mEventEmitters.size() ; i++) {
-      RCTEventEmitter eventEmitter = mEventEmitters.valueAt(i);
-      if (eventEmitter instanceof Closeable) {
-        try {
-          ((Closeable) eventEmitter).close();
-        } catch (IOException e) {
-          Log.i(TAG, "Exception when closing EventEmitter: " + eventEmitter, e);
-        }
-      }
-    }
-  }
 }