Skip to content

Commit

Permalink
Build RN Tester with CMake (#33937)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #33937

This moves the build of RNTester from Unix Make to CMake
This will serve as a blueprint for users that are looking into using CMake end-to-end in their buildls.

In order to make this possible I had to:
* Add an `Android-prebuilt.cmake` file that works similar to the `Android-prebuilt.mk` for feeding prebuilt .so files to the consumer build.
* Update the codegen to use `JSI_EXPORT` on several objects/classes as CMake has stricter visibility rules than Make
* Update the sample native module in `nativemodule/samples/platform/android/` to use CMake instead of Make

Changelog:
[Internal] [Changed] - Build RN Tester with CMake

Reviewed By: cipolleschi

Differential Revision: D36760309

fbshipit-source-id: b99449a4b824b6c0064e833d4bcd5969b141df70
  • Loading branch information
cortinico authored and facebook-github-bot committed Jun 6, 2022
1 parent a9659ce commit f1c614b
Show file tree
Hide file tree
Showing 17 changed files with 545 additions and 181 deletions.
231 changes: 231 additions & 0 deletions ReactAndroid/cmake-utils/Android-prebuilt.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,231 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

# This configuration provides access to most common React Native prebuilt .so files
# to avoid recompiling each of the libraries outside of ReactAndroid NDK compilation.
# Hosting app's/library's CMakeLists.txt can include this Android-prebuilt.cmake file to
# get access to those libraries to depend on.
# NOTES:
# * Currently, it assumes building React Native from source.
# * Not every .so is listed here (yet).
# * Static libs are not covered here (yet).

cmake_minimum_required(VERSION 3.13)
set(CMAKE_VERBOSE_MAKEFILE on)

# FIRST_PARTY_NDK_DIR contains vendored source code from other FB frameworks
# like Yoga, FBJNI, etc.
set(FIRST_PARTY_NDK_DIR ${REACT_ANDROID_DIR}/src/main/jni/first-party)
# THIRD_PARTY_NDK_DIR is where we're downloading third-party native
# frameworks such as libevent, boost, etc.
set(THIRD_PARTY_NDK_DIR ${REACT_ANDROID_BUILD_DIR}/third-party-ndk)
# REACT_ANDROID_SRC_DIR is the root of ReactAndroid source code (Java & JNI)
set(REACT_ANDROID_SRC_DIR ${REACT_ANDROID_DIR}/src/main)
# REACT_COMMON_DIR is the root of ReactCommon source code (C++ only)
set(REACT_COMMON_DIR ${REACT_ANDROID_DIR}/../ReactCommon)
# REACT_GENERATED_SRC_DIR is the folder where the codegen for rncore will output
set(REACT_GENERATED_SRC_DIR ${REACT_ANDROID_BUILD_DIR}/generated/source)
# REACT_NDK_EXPORT_DIR is the folder where the .so will be copied for being inported
# in the local project by the packageReactDebugNdkLibs/packageReactReleaseNdkLibs
set(REACT_NDK_EXPORT_DIR ${PROJECT_BUILD_DIR}/react-ndk/exported)

## fb
add_library(fb SHARED IMPORTED GLOBAL)
set_target_properties(fb
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libfb.so)
target_include_directories(fb
INTERFACE
${FIRST_PARTY_NDK_DIR}/fb/include)

## folly_runtime
add_library(folly_runtime SHARED IMPORTED GLOBAL)
set_target_properties(folly_runtime
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libfolly_runtime.so)
target_include_directories(folly_runtime
INTERFACE
${THIRD_PARTY_NDK_DIR}/boost/boost_1_76_0
${THIRD_PARTY_NDK_DIR}/double-conversion
${THIRD_PARTY_NDK_DIR}/folly)
target_compile_options(folly_runtime
INTERFACE
-DFOLLY_NO_CONFIG=1
-DFOLLY_HAVE_CLOCK_GETTIME=1
-DFOLLY_HAVE_MEMRCHR=1
-DFOLLY_USE_LIBCPP=1
-DFOLLY_MOBILE=1
-DFOLLY_HAVE_XSI_STRERROR_R=1)

## glog
add_library(glog SHARED IMPORTED GLOBAL)
set_target_properties(glog
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libglog.so)
target_include_directories(glog INTERFACE ${THIRD_PARTY_NDK_DIR}/glog/exported)

## yoga
add_library(yoga SHARED IMPORTED GLOBAL)
set_target_properties(yoga
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libyoga.so)
target_include_directories(yoga
INTERFACE
${FIRST_PARTY_NDK_DIR}/yogajni/jni
${REACT_COMMON_DIR}/yoga)
target_compile_options(yoga
INTERFACE
-fvisibility=hidden
-fexceptions
-frtti
-O3)
target_link_libraries(yoga INTERFACE log android)

## react_nativemodule_core
add_library(react_nativemodule_core SHARED IMPORTED GLOBAL)
set_target_properties(react_nativemodule_core
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_nativemodule_core.so)
target_include_directories(react_nativemodule_core
INTERFACE
${REACT_ANDROID_SRC_DIR}/jni
${REACT_COMMON_DIR}
${REACT_COMMON_DIR}/callinvoker
${REACT_COMMON_DIR}/jsi
${REACT_COMMON_DIR}/react/nativemodule/core
${REACT_COMMON_DIR}/react/nativemodule/core/platform/android)
target_link_libraries(react_nativemodule_core INTERFACE folly_runtime)

## turbomodulejsijni
add_library(turbomodulejsijni SHARED IMPORTED GLOBAL)
set_target_properties(turbomodulejsijni
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libturbomodulejsijni.so)
target_include_directories(turbomodulejsijni
INTERFACE
${REACT_ANDROID_SRC_DIR}/java/com/facebook/react/turbomodule/core/jni)

## react_render_core
add_library(react_render_core SHARED IMPORTED GLOBAL)
set_target_properties(react_render_core
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_render_core.so)
target_include_directories(react_render_core
INTERFACE
${REACT_COMMON_DIR}
${REACT_COMMON_DIR}/react/renderer/core)

## react_render_debug
add_library(react_render_debug SHARED IMPORTED GLOBAL)
set_target_properties(react_render_debug
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_render_debug.so)
target_include_directories(react_render_debug INTERFACE ${REACT_COMMON_DIR}/react/renderer/debug)

## react_debug
add_library(react_debug SHARED IMPORTED GLOBAL)
set_target_properties(react_debug
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_debug.so)
target_include_directories(react_debug INTERFACE ${REACT_COMMON_DIR}/react/debug)
target_link_libraries(react_nativemodule_core INTERFACE folly_runtime)

## react_render_graphics
add_library(react_render_graphics SHARED IMPORTED GLOBAL)
set_target_properties(react_render_graphics
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_render_graphics.so)
target_include_directories(react_render_graphics
INTERFACE
${REACT_COMMON_DIR}/react/renderer/graphics
${REACT_COMMON_DIR}/react/renderer/graphics/platform/cxx)

## react_render_imagemanager
add_library(react_render_imagemanager SHARED IMPORTED GLOBAL)
set_target_properties(react_render_imagemanager
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_render_imagemanager.so)
target_include_directories(react_render_imagemanager
INTERFACE
${REACT_COMMON_DIR}/react/renderer/imagemanager
${REACT_COMMON_DIR}/react/renderer/imagemanager/platform/cxx)

## react_render_mounting
add_library(react_render_mounting SHARED IMPORTED GLOBAL)
set_target_properties(react_render_mounting
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_render_mounting.so)
target_include_directories(react_render_mounting INTERFACE ${REACT_COMMON_DIR}/react/renderer/mounting)

## react_render_mapbuffer
add_library(react_render_mapbuffer SHARED IMPORTED GLOBAL)
set_target_properties(react_render_mapbuffer
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_render_mapbuffer.so)
target_include_directories(react_render_mapbuffer INTERFACE ${REACT_COMMON_DIR}/react/renderer/mapbuffer)

## rrc_view
add_library(rrc_view SHARED IMPORTED GLOBAL)
set_target_properties(rrc_view
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/librrc_view.so)
target_include_directories(rrc_view INTERFACE ${REACT_COMMON_DIR}/react/renderer/components/view)

## fabricjni
add_library(fabricjni SHARED IMPORTED GLOBAL)
set_target_properties(fabricjni
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libfabricjni.so)
target_include_directories(fabricjni INTERFACE ${REACT_ANDROID_SRC_DIR}/java/com/facebook/react/fabric/jni)

## react_render_componentregistry
add_library(react_render_componentregistry SHARED IMPORTED GLOBAL)
set_target_properties(react_render_componentregistry
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_render_componentregistry.so)
target_include_directories(react_render_componentregistry INTERFACE ${REACT_COMMON_DIR}/react/renderer/componentregistry)

## jsi
add_library(jsi SHARED IMPORTED GLOBAL)
set_target_properties(jsi
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libjsi.so)
target_include_directories(jsi INTERFACE ${REACT_COMMON_DIR}/jsi)

## react_codegen_rncore
add_library(react_codegen_rncore SHARED IMPORTED GLOBAL)
set_target_properties(react_codegen_rncore
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libreact_codegen_rncore.so)
target_include_directories(react_codegen_rncore INTERFACE ${REACT_GENERATED_SRC_DIR}/codegen/jni)

## runtimeexecutor
add_library(runtimeexecutor SHARED IMPORTED GLOBAL)
set_target_properties(runtimeexecutor
PROPERTIES
IMPORTED_LOCATION
${REACT_NDK_EXPORT_DIR}/${ANDROID_ABI}/libruntimeexecutor.so)
target_include_directories(runtimeexecutor INTERFACE ${REACT_COMMON_DIR}/runtimeexecutor)

## fbjni
add_subdirectory(${FIRST_PARTY_NDK_DIR}/fbjni fbjni_build)
23 changes: 0 additions & 23 deletions ReactCommon/react/nativemodule/samples/platform/android/Android.mk

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

cmake_minimum_required(VERSION 3.13)
set(CMAKE_VERBOSE_MAKEFILE on)

add_compile_options(-fexceptions -frtti -std=c++17 -Wall -DLOG_TAG=\"ReactNative\")

file(GLOB sampleturbomodule_SRC CONFIGURE_DEPENDS ReactCommon/*.cpp)
add_library(sampleturbomodule STATIC ${sampleturbomodule_SRC})

target_include_directories(sampleturbomodule PUBLIC .)

target_link_libraries(sampleturbomodule
fbjni
jsi
react_nativemodule_core)
Loading

0 comments on commit f1c614b

Please sign in to comment.