Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed crash on attempt to update local data of deallocated shadow node
Summary: Trivial. That's okay that sometimes shadowNodes and views hierarchies have lack of synchonization. Reviewed By: sahrens Differential Revision: D6040022 fbshipit-source-id: 6b49a82317b620b66a87441719fddcafb1f27934
- Loading branch information
f2c6877
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's ok that they are not in sync. Why is there a warning at all?
f2c6877
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't this backported to 0.50.x?
f2c6877
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to backport this to 0.50.x. This is currently blocking a deploy for us. I either have to try to go back to 0.49 or release with a 0.51 RC.
f2c6877
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great to hear
f2c6877
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great