Skip to content

Commit

Permalink
Fix setupReactContext systrace
Browse files Browse the repository at this point in the history
Summary: setupReactContext wasn't ending because D9664719 added incorrect end markers. Need to use either Systrace.endSection() or SystraceMessage.endSection().flush().

Differential Revision: D9695854

fbshipit-source-id: e0f7d492bc58536ce242962438edac7eec671867
  • Loading branch information
ayc1 authored and facebook-github-bot committed Sep 7, 2018
1 parent c3e42b5 commit f38ab24
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ private static Map<String, Object> createConstants(ViewManagerResolver viewManag
try {
return UIManagerModuleConstantsHelper.createConstants(viewManagerResolver);
} finally {
SystraceMessage.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE);
Systrace.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE);
ReactMarker.logMarker(CREATE_UI_MANAGER_MODULE_CONSTANTS_END);
}
}
Expand All @@ -237,7 +237,7 @@ private static Map<String, Object> createConstants(
return UIManagerModuleConstantsHelper.createConstants(
viewManagers, customBubblingEvents, customDirectEvents);
} finally {
SystraceMessage.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE);
Systrace.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE);
ReactMarker.logMarker(CREATE_UI_MANAGER_MODULE_CONSTANTS_END);
}
}
Expand Down

0 comments on commit f38ab24

Please sign in to comment.