Fabric: Sharing a pointer to ShadowTreeRegister with UIManager

Summary: The diff adds a pointer to ShadowTreeRegistry to UIManager which enables the possibility of implementing ShadowTree mutating and inspecting methods like `setNativeProps` and `getRelativeLayoutMetrics`. Reviewed By: mdvacca Differential Revision: D13036549 fbshipit-source-id: 5ed1252d84c8dd895fe0e6e8cc71afbaa9dab4b7
facebook · Nov 22, 2018 · f8be867 · f8be867
1 parent b4fa1fa
commit f8be867
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/ReactCommon/fabric/uimanager/Scheduler.cpp b/ReactCommon/fabric/uimanager/Scheduler.cpp
@@ -49,6 +49,7 @@ Scheduler::Scheduler(const SharedContextContainer &contextContainer)
       eventDispatcher, contextContainer);
 
   uiManagerRef.setDelegate(this);
+  uiManagerRef.setShadowTreeRegistry(&shadowTreeRegistry_);
   uiManagerRef.setComponentDescriptorRegistry(componentDescriptorRegistry_);
 
   runtimeExecutor_([=](jsi::Runtime &runtime) {

diff --git a/ReactCommon/fabric/uimanager/UIManager.cpp b/ReactCommon/fabric/uimanager/UIManager.cpp
@@ -67,6 +67,10 @@ void UIManager::completeSurface(
   }
 }
 
+void UIManager::setShadowTreeRegistry(ShadowTreeRegistry *shadowTreeRegistry) {
+  shadowTreeRegistry_ = shadowTreeRegistry;
+}
+
 void UIManager::setComponentDescriptorRegistry(
     const SharedComponentDescriptorRegistry &componentDescriptorRegistry) {
   componentDescriptorRegistry_ = componentDescriptorRegistry;

diff --git a/ReactCommon/fabric/uimanager/UIManager.h b/ReactCommon/fabric/uimanager/UIManager.h
@@ -8,13 +8,16 @@
 
 #include <react/core/ShadowNode.h>
 #include <react/uimanager/ComponentDescriptorRegistry.h>
+#include <react/uimanager/ShadowTreeRegistry.h>
 #include <react/uimanager/UIManagerDelegate.h>
 
 namespace facebook {
 namespace react {
 
 class UIManager {
  public:
+  void setShadowTreeRegistry(ShadowTreeRegistry *shadowTreeRegistry);
+
   void setComponentDescriptorRegistry(
       const SharedComponentDescriptorRegistry &componentDescriptorRegistry);
 
@@ -49,6 +52,7 @@ class UIManager {
       SurfaceId surfaceId,
       const SharedShadowNodeUnsharedList &rootChildren) const;
 
+  ShadowTreeRegistry *shadowTreeRegistry_;
   SharedComponentDescriptorRegistry componentDescriptorRegistry_;
   UIManagerDelegate *delegate_;
 };

diff --git a/ReactCommon/fabric/uimanager/UIManagerBinding.cpp b/ReactCommon/fabric/uimanager/UIManagerBinding.cpp
@@ -90,6 +90,7 @@ void UIManagerBinding::dispatchEvent(
 }
 
 void UIManagerBinding::invalidate() const {
+  uiManager_->setShadowTreeRegistry(nullptr);
   uiManager_->setDelegate(nullptr);
 }