Skip to content

Commit

Permalink
Image: remove unused ImageProps (#28151)
Browse files Browse the repository at this point in the history
Summary:
I noticed that there was a `height` and `width` props in `Image` component, but those props are not being used in `RCTImageView`(ios) or `ReactImageView`(android).

## Changelog

[GENERAL] [Removed] - Remove Unused ImageProp
Pull Request resolved: #28151

Test Plan: Start a new React Native Project, and use `Image` component with `width` and `height` props and verify that it does not display the image on both iOS and Android

Reviewed By: shergin

Differential Revision: D20197126

Pulled By: TheSavior

fbshipit-source-id: 186119448826659d7c01c7c8a271157228169c30
  • Loading branch information
Naturalclar authored and facebook-github-bot committed Mar 5, 2020
1 parent c203ec0 commit fbd09b1
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions Libraries/Image/ImageProps.js
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,6 @@ export type ImageProps = {|
*/
style?: ?ImageStyleProp,

// Can be set via props or style, for now
height?: ?DimensionValue,
width?: ?DimensionValue,

/**
* Determines how to resize the image when the frame doesn't match the raw
* image dimensions.
Expand Down

0 comments on commit fbd09b1

Please sign in to comment.