java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.uimanager.ReactShadowNode.setStyleWidth(float)' on a null object reference #10845

akzhou · 2016-11-10T05:29:08Z

Android tablet,when I assembleRelease the apk,modal view crash. debug not found this question.

java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.uimanager.ReactShadowNode.setStyleWidth(float)' on a null object reference at com.facebook.react.uimanager.UIImplementation.updateNodeSize(UIImplementation.java:151) at com.facebook.react.uimanager.UIManagerModule.updateNodeSize(UIManagerModule.java:213) at com.facebook.react.views.modal.ReactModalHostView$DialogRootViewGroup$1.run(ReactModalHostView.java:302) at android.os.Handler.handleCallback(Handler.java:815) at android.os.Handler.dispatchMessage(Handler.java:104) at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31) at android.os.Looper.loop(Looper.java:194) at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:196) at java.lang.Thread.run(Thread.java:818)

Additional Information

React Native version: 0.36.1,0.37
Platform: android
Operating System: mac os

The text was updated successfully, but these errors were encountered:

ettysekhon · 2016-11-11T09:53:05Z

I have found the same issue on release APK alse see #10795

ettysekhon · 2016-11-11T12:23:50Z

@akzhou I solved this by using the InteractionManager runAfterInteractions in a ComponentDidMount, see below for further details:

https://github.com/brentvatne/run-after-interactions-exp/blob/master/index.js

ettysekhon · 2016-11-11T12:24:01Z

@akzhou I solved this by using the InteractionManager runAfterInteractions in a ComponentDidMount, see below for further details:

https://github.com/brentvatne/run-after-interactions-exp/blob/master/index.js

akzhou · 2016-11-16T09:09:16Z

@ettysekhon it seem that you use renderPlaceholder replace modal view.at last,I fix it by compile the react-native source code with modify ReactModalHostView.java onSizeChanged method
protected void onSizeChanged(final int w, final int h, int oldw, int oldh) { super.onSizeChanged(w, h, oldw, oldh); return }
i don't know how the code work,at least no crash

xujinyang · 2016-11-22T06:18:14Z

@akzhou can you push an PR to facebook？

nadeermalangadan · 2016-11-22T09:34:42Z

+1

bawn · 2016-11-25T10:27:53Z

+1

Proberts · 2016-11-29T10:45:28Z

This fix looks like it removes some important functionality.

FWIW I have this reproducible using redux and saga. I have a bool state variable mapped to a Modal component's 'visible" property. I change the state from false to true at the start of the saga. If I change the state back to false in the same saga I get this error consistently.

It seems like a safer band-aid would be to put a null test at line 151 (RN 0.37) in UIImplementation.java:

public void updateNodeSize(
      int nodeViewTag,
      int newWidth,
      int newHeight) {
    ReactShadowNode cssNode = mShadowNodeRegistry.getNode(nodeViewTag);
      if( cssNode != null ) {  // <-- right here
        cssNode.setStyleWidth(newWidth);
        cssNode.setStyleHeight(newHeight);
      }

    // If we're in the middle of a batch, the change will automatically be dispatched at the end of
    // the batch. As all batches are executed as a single runnable on the event queue this should
    // always be empty, but that calling architecture is an implementation detail.
    if (mOperationsQueue.isEmpty()) {
      dispatchViewUpdates(-1); // -1 = no associated batch id
    }
  }

idris · 2016-11-29T18:23:03Z

@Proberts can you create an app that reproduces this issue on https://rnplay.org and then attach it to #10795?

Proberts · 2016-11-29T19:14:19Z

@idris Trying but it looks like I can't import redux-saga. Not sure how to implement it without as I'm new to RN. I can try to make a minimal app that shows the problem and stick it on github. Would that help?

idris · 2016-12-01T20:48:03Z

@Proberts yeah that would probably be useful for react-native devs to have a way to reproduce it.

jjdp · 2016-12-08T09:16:01Z

+1

Proberts · 2016-12-08T10:08:18Z

FWIW I can't get it to reproduce in a minimal setup with the way I thought it was getting triggered in my code. I had it go away for a while after I moved some code being called from an onPress event handler into a saga. But it came back after I added to async calls to the saga - so at least I have a place to start looking.

jideobs · 2016-12-08T17:03:37Z

This problem is fresh. +1

astapinski · 2016-12-09T02:56:10Z

We're also encountering this crash on Google Android emulators API 23, RN 0.35 with automated runs via Calabash. We haven't seen it (yet thankfully?) on physical devices, but it's pretty annoying to have our automation fail so randomly. It also happens around the time of a modal display.

madox2 · 2016-12-16T18:16:12Z

I am having the same issue. I have modal (fullscreen) and android keyboard on. It happens when I close it with enter key (onSubmitEditing). I've tried to close modal in InteractionManager.runAfterInteractions callback, but it didn't help.
However It seems to be working when I postpone it with setTimeout(..., 300)

WPCWEG · 2016-12-22T06:11:44Z

I have the same question on React Native
Version: 0.30.0
Platform: Android (Coolpad A8-930)

miller · 2016-12-27T01:55:13Z

+1

yinghang · 2016-12-29T07:11:14Z

Any updates?

rohitgoyal · 2016-12-30T15:57:46Z

Any updates?

rusel1989 · 2016-12-31T04:31:43Z

Yeah this bug is pretty nasty, i've got 2 bad reviews in play store because of it ...
I've used this fix

const CustomModal = ({ visible = false, children }) => {
  if (!visible) {
    return <View/>
  }
  return (
    <Modal
      style={styles.modalWrapper}
      animationType='slide'
      onRequestClose={() => {}}
      visible={true}
      transparent >
      {children}
    </Modal>
  )
}

Nothing fancy, but works okay

raymond-cat · 2017-01-12T10:49:57Z

I have the same question on React Native
Version: 0.39.0
Platform: Android

SeanYe · 2017-01-13T04:22:19Z

+1

Proberts · 2017-01-13T06:54:24Z

I haven't seen this problem since I upgraded to 0.39.2 It might have been fixed by this commit

K-Leon · 2017-01-17T11:04:17Z

I've just seen it with 0.41-rc

alex44jzy · 2017-01-18T12:21:37Z

+1 the same problem in RN 0.39 Android 4.4.4. Also cause with the Modal. I am a little upset.

RobTS · 2017-01-18T15:37:54Z

Experiencing this randomly on startup as well. 0.4.0

PierrePIRONIN · 2017-01-18T15:42:37Z

+1 with version 0.40

astreet · 2017-03-20T11:16:09Z

@grabbou This should be pretty safe to merge, what release can we get this into do you think?

grabbou · 2017-03-20T21:33:19Z

Yeah, I'll include it in next RC tomorrow.

Patch Error: ReactShadowNode.setStyleWidth(float)' on a null object reference facebook#10845 facebook/react-native@5873a22

aamir-munir · 2017-03-25T07:44:48Z

I am using RN 0.42.3, but I am still getting this error randomly on application start.

cemo · 2017-03-25T12:23:05Z

@itcurves give a try with v0.43.0-rc.4. I think that this release contains necessary patch as @grabbou stated.

TaranjeetSinghWri · 2017-03-27T06:08:59Z

I added a delay of 1 second before showing the infected view page, which solved the issue temporarily

TaranjeetSinghWri · 2017-03-27T06:11:46Z

I think it is related to react-native-router-flux

dcp12345678 · 2017-03-27T12:32:37Z

@cemo

I have not been able to run this release. I followed the documentation located here to upgrade to this release version you mentioned in your post, but when I try to do 'react-native run-android', this is what I get (see below). Is there any documentation for how to install one of these release versions?

What went wrong:
A problem occurred configuring project ':app'.

Could not resolve all dependencies for configuration ':app:_debugApkCopy'.
Could not resolve com.facebook.fresco:fresco:1.0.1.
Required by:
OrderEntry:app:unspecified > com.facebook.react:react-native:0.43.0-rc.
4
> Could not resolve com.facebook.fresco:fresco:1.0.1.
> Could not get resource 'https://jcenter.bintray.com/com/facebook/fres
co/fresco/1.0.1/fresco-1.0.1.pom'.
> Could not GET 'https://jcenter.bintray.com/com/facebook/fresco/fre
sco/1.0.1/fresco-1.0.1.pom'.
> jcenter.bintray.com
Could not resolve com.facebook.fresco:imagepipeline-okhttp3:1.0.1.
Required by:
OrderEntry:app:unspecified > com.facebook.react:react-native:0.43.0-rc.
4
> Could not resolve com.facebook.fresco:imagepipeline-okhttp3:1.0.1.
> Could not get resource 'https://jcenter.bintray.com/com/facebook/fres
co/imagepipeline-okhttp3/1.0.1/imagepipeline-okhttp3-1.0.1.pom'.
> Could not GET 'https://jcenter.bintray.com/com/facebook/fresco/ima
gepipeline-okhttp3/1.0.1/imagepipeline-okhttp3-1.0.1.pom'.
> jcenter.bintray.com

liubobuzhidao · 2017-03-28T06:04:30Z

@itcurves Do you have resolved this problem?

kelvinaliyanto · 2017-04-08T18:00:25Z

Is this issue already fixed in the latest release? Because I just checked my crashlytics and this issue seems to appear quite often.

tianxind · 2017-04-10T05:15:06Z

So this commit is not in RN 0.43?

…er JS has removed it Summary: See #10845 onSizeChanged is enqueueing a runnable from the ui thread that references a shadow view by id on the native modules thread. Since the shadow thread 'runs ahead' of the UI thread (e.g. it has a newer state of the world than the UI thread), this isn't safe. By the time that code block runs, it's possible that an update from JS has already removed that view from the shadow hierarchy (a change which would then propagate to the native hierarchy on the UI thread). Reviewed By: AaaChiuuu Differential Revision: D4706521 fbshipit-source-id: 0915f081068709b895f70b2edce12163b39e5456

grabbou · 2017-04-10T10:11:44Z

Looks like the commit didn't end up in 0.43 release by a mistake. I have released a new version (0.43.3) along with some other smaller tweaks.

…

On Mon, 10 Apr 2017 at 07:16 tianxind ***@***.***> wrote: So this commit is not in RN 0.43? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10845 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxkgG5jsmLZWEWvcEXF3xrKMfBofzks5rubsTgaJpZM4KuSyA> .

phamtn8 · 2017-05-04T04:51:10Z

anyone confirm that this is fixed for RN 0.44?

zubryan · 2017-05-10T09:34:29Z

Any update? We have the same issue with RN 0.41.2
RN 0.44 is ok?

astreet · 2017-05-10T10:55:49Z

Yes, .44 should be fine as it's listed in the release notes: https://github.com/facebook/react-native/releases/tag/v0.44.0

…er JS has removed it Summary: See facebook#10845 onSizeChanged is enqueueing a runnable from the ui thread that references a shadow view by id on the native modules thread. Since the shadow thread 'runs ahead' of the UI thread (e.g. it has a newer state of the world than the UI thread), this isn't safe. By the time that code block runs, it's possible that an update from JS has already removed that view from the shadow hierarchy (a change which would then propagate to the native hierarchy on the UI thread). Reviewed By: AaaChiuuu Differential Revision: D4706521 fbshipit-source-id: 0915f081068709b895f70b2edce12163b39e5456

39otrebla · 2017-09-15T07:22:36Z

Still happening on my side, without using any Modal (I am using react native navigation and its built-in Modal).

platform: Android (min api 21)
react-native: 0.48.3

couldhll · 2017-11-22T03:53:47Z

+1

mehmetcanker · 2017-11-22T21:26:27Z

+1

Shinichi52 · 2017-11-27T14:30:57Z

+1

etruta · 2017-12-19T14:52:41Z

+1

fxalvarezd · 2018-01-29T21:03:32Z

@astreet not sure if you have any input on this. I have the same issue as @39otrebla described.
It's really random on our end and almost never happens, but when it does it's when transitioning to a screen.
We're running react-native: 0.48.4 and react-native-navigation: ^1.1.300.

facebook/react-native#10845

wenkangzhou · 2018-06-01T10:21:47Z

Still happening in 0.49.5

8of · 2018-07-12T20:54:31Z

The issue is still here, unfortunately.
React Native 0.55.4, 0.56.0
Android 8

idris mentioned this issue Nov 29, 2016

NullPointerException when showing Android Modal #10795

Closed

RobTS mentioned this issue Jan 18, 2017

Some times cause app crash. ladjs/react-native-loading-spinner-overlay#28

Closed

gregberns added a commit to gregberns/react-native that referenced this issue Mar 23, 2017

patch: setStyleWidth(float)' on a null

72d5a83

Patch Error: ReactShadowNode.setStyleWidth(float)' on a null object reference facebook#10845 facebook/react-native@5873a22

grabbou closed this as completed May 11, 2017

skv-headless mentioned this issue Jul 28, 2017

Attempt to invoke virtual method 'void com.facebook.react.uimanager.ReactShadowNode.setStyleWidth(float)' on a null object reference ptomasroos/react-native-scrollable-tab-view#677

Closed

ocleo1 pushed a commit to ocleo1/react-native-lets-rock-poc that referenced this issue Mar 8, 2018

Remove LoadingMask for now, since Modal got issue in Android of 0.42.3

0773ab7

facebook/react-native#10845

facebook locked as resolved and limited conversation to collaborators Jul 19, 2018

react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018

java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.uimanager.ReactShadowNode.setStyleWidth(float)' on a null object reference #10845

java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.uimanager.ReactShadowNode.setStyleWidth(float)' on a null object reference #10845

Comments

akzhou commented Nov 10, 2016 • edited Loading

Additional Information

ettysekhon commented Nov 11, 2016 • edited Loading

ettysekhon commented Nov 11, 2016

ettysekhon commented Nov 11, 2016

akzhou commented Nov 16, 2016

xujinyang commented Nov 22, 2016

nadeermalangadan commented Nov 22, 2016

bawn commented Nov 25, 2016

Proberts commented Nov 29, 2016 • edited Loading

idris commented Nov 29, 2016 • edited Loading

Proberts commented Nov 29, 2016

idris commented Dec 1, 2016

jjdp commented Dec 8, 2016

Proberts commented Dec 8, 2016

jideobs commented Dec 8, 2016 • edited Loading

astapinski commented Dec 9, 2016 • edited Loading

madox2 commented Dec 16, 2016

WPCWEG commented Dec 22, 2016

miller commented Dec 27, 2016

yinghang commented Dec 29, 2016

rohitgoyal commented Dec 30, 2016

rusel1989 commented Dec 31, 2016

raymond-cat commented Jan 12, 2017

SeanYe commented Jan 13, 2017

Proberts commented Jan 13, 2017

K-Leon commented Jan 17, 2017

alex44jzy commented Jan 18, 2017

RobTS commented Jan 18, 2017 • edited Loading

PierrePIRONIN commented Jan 18, 2017 • edited Loading

astreet commented Mar 20, 2017

grabbou commented Mar 20, 2017

aamir-munir commented Mar 25, 2017

cemo commented Mar 25, 2017

TaranjeetSinghWri commented Mar 27, 2017

TaranjeetSinghWri commented Mar 27, 2017

dcp12345678 commented Mar 27, 2017

liubobuzhidao commented Mar 28, 2017

kelvinaliyanto commented Apr 8, 2017

tianxind commented Apr 10, 2017

grabbou commented Apr 10, 2017 via email

phamtn8 commented May 4, 2017

zubryan commented May 10, 2017

astreet commented May 10, 2017

39otrebla commented Sep 15, 2017

couldhll commented Nov 22, 2017

mehmetcanker commented Nov 22, 2017

Shinichi52 commented Nov 27, 2017

etruta commented Dec 19, 2017

fxalvarezd commented Jan 29, 2018

wenkangzhou commented Jun 1, 2018

8of commented Jul 12, 2018

akzhou commented Nov 10, 2016 •

edited

Loading

ettysekhon commented Nov 11, 2016 •

edited

Loading

Proberts commented Nov 29, 2016 •

edited

Loading

idris commented Nov 29, 2016 •

edited

Loading

jideobs commented Dec 8, 2016 •

edited

Loading

astapinski commented Dec 9, 2016 •

edited

Loading

RobTS commented Jan 18, 2017 •

edited

Loading

PierrePIRONIN commented Jan 18, 2017 •

edited

Loading