Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigator FloatFromLeft Scene Config #1100

Closed
hoodsy opened this issue May 1, 2015 · 3 comments
Closed

Navigator FloatFromLeft Scene Config #1100

hoodsy opened this issue May 1, 2015 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@hoodsy
Copy link
Contributor

hoodsy commented May 1, 2015

would it be possible to have a FloatFromLeft animation?

would b nice for the UX =]
@ide
Copy link
Contributor

ide commented May 1, 2015

I believe you could write this without needing to make changes to the core project by writing a scene config that mirrors FloatFromRight and providing it to the Navigator.

@ericvicenti
Copy link
Contributor

Yep, you can write custom scene configs for Navigator in your app. If you think others would be interested in FloatFromLeft, you could send a pull request to the default configs file:

https://github.com/facebook/react-native/blob/master/Libraries/CustomComponents/Navigator/NavigatorSceneConfigs.js

@ericvicenti ericvicenti changed the title SceneConfig Animations Navigator FloatFromLeft Scene Config May 4, 2015
@hoodsy
Copy link
Contributor Author

hoodsy commented May 4, 2015

ok. thanks

@hoodsy hoodsy mentioned this issue May 12, 2015
Closed
vjeux pushed a commit to vjeux/react-native that referenced this issue May 13, 2015
@hoodsy
FloatFromLeft animation
4371ceb 
Summary:
float from left animation for Navigator.SceneConfigs

facebook#1100
@ericvicenti
@ide
Closes facebook#1249
Github Author: Logan Bernard <bernard.logan4@gmail.com>

@public

Test Plan: Video: https://drive.google.com/file/d/0B9HtmABaCcR0Zi1yNkl5UDhWbzg/view
vjeux pushed a commit to vjeux/react-native that referenced this issue May 13, 2015
@hoodsy @vjeux
FloatFromLeft animation
2ed2d20 
Summary:
float from left animation for Navigator.SceneConfigs

facebook#1100
@ericvicenti
@ide
Closes facebook#1249
Github Author: Logan Bernard <bernard.logan4@gmail.com>

@public

Test Plan: Video: https://drive.google.com/file/d/0B9HtmABaCcR0Zi1yNkl5UDhWbzg/view
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brentvatne @ide @ericvicenti @hoodsy @react-native-bot