-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifacts on View with borderRadius on only 2 corners on iOS #11897
Comments
I confirm, this is a nasty issue (iOS only). However in case you don't need different outer border colors/styles/widths on your blocks, you can wrap both views in a container and give it overflow:'hidden' along with needed borderRadius:6 instead of each half separately. |
try using |
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
same issue |
Got same for RN 0.47 and iPhone 6 In my case, it looks like exactly the same as in kirankalyan5/react-native-segmented-control-tab#10 Folks in issue above describes how to get workaround, but source problem still exists in RN |
Still an issue. Reopen and fix the bug. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
Facing similar issue |
It was fixed in master. |
@SupriyaKalghatgi did you try |
@ismdcf Whats difference between snippet i shared and that of yours? |
@zinoviev Is it happened on master? Have you tried this on Simulator with same pixel density as device? |
@SupriyaKalghatgi I tested with 0.55.3 |
I still find this issue with iOS 11 |
@SupriyaKalghatgi which fix? Can you link to the PR? |
@hramos You can check the above conversation |
0.55.4 Still there. I'm peeking at https://github.com/facebook/react-native/blob/master/React/Views/RCTBorderDrawing.m in which I think the bug is caused. But it's pretty mumbo jumbo at first sight... |
@SupriyaKalghatgi in that case, this issue is open and waiting for a fix from the community. Feel free to send a PR. Thanks! |
@hramos Yes, i know that the issue is still kept open Without any fix! |
I dont think i am free enough to send PR |
@SupriyaKalghatgi I assume you one of nativebase maintainers and if you facing this issue for segmented controls it's pretty easy to implement workaround - remove opposite to round corners border with applying a style like borderRightWidth: 0. Bleeding is happening on the side without border-radius, so just remove this side entirely and let another view be its border. You may use 1pt width view if you don't have a logical neighbor. |
I did create PR #19451 It would be great if some people can confirm if it is fixed. |
I just tested on iOS 12 beta. Same problem. My PR fixes it there too though. |
Maybe someone will help it: P.S.: Tested on iPhone 6 (real device) |
@Damirikys issue still there if the borderRadius is more than the borderWidth. |
I'm facing this same issue, only in iOS (tested on iPhone 5s). React-native version 0.55.4.
-- |
Same issue here on Views with React-Native version 0.57.0 and Android |
#21208 has been merged and the fix is now in |
Summary: Fixes #22824 #21945 , the bug comes from #21208 , it was to fix #11897. Now Let's constrain edge adjust only when view has corners. [iOS] [Fixed] - Fix triangle views on iOS Pull Request resolved: #23402 Differential Revision: D14059192 Pulled By: hramos fbshipit-source-id: be613bf056d3cc484f281f7ea3d08f251971700a
Summary: Fixes #22824 #21945 , the bug comes from #21208 , it was to fix #11897. Now Let's constrain edge adjust only when view has corners. [iOS] [Fixed] - Fix triangle views on iOS Pull Request resolved: #23402 Differential Revision: D14059192 Pulled By: hramos fbshipit-source-id: be613bf056d3cc484f281f7ea3d08f251971700a
Description
I need a couple of Views with border radius only on the top or bottom corners, to use as container for TextInputs (its a email/password form).
Reproduction
Using this code:
The result is as expected, but with artifacts on the corners with radius:0
Solution
Don't know yet
Additional Information
The text was updated successfully, but these errors were encountered: