-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget suggestion : Carousel #132
Comments
What do you want different exactly? Did you set the pagination prop true?
|
Maybe this is an opportunity to make this feature more developer-friendly? I had no idea that something called "pagination" would be used as a carousel. I'm used to pagination meaning "pages of data queried and viewed". :-\ I imagine there could be an extension to ScrollView called a Carousel that sets pagingEnabled to true by default and renders indicators. |
That could be handy - a component could also do some processing of the raw onScroll data to provide onChangeCard. Want to send a PR?
|
@nick the Carousel sounds awesome. Unfortunately https://github.com/nick/react-native/blob/master/Examples/Weather/js/components/Carousel.js leads to a 404. |
@ppong oops - try now |
@nick thanks! it works now 👍 |
I've now released this as an npm module at http://github.com/nick/react-native-carousel |
@nick - nice one, thanks! 👍 |
Summary: Added baseline support (see #132) You have the ability for a custom baseline function (```float(*YGBaselineFunc)(YGNodeRef node);```) to return whatever baseline you want. Closes facebook/yoga#317 Reviewed By: splhack Differential Revision: D4385061 Pulled By: emilsjolander fbshipit-source-id: cb8a59a09237c840fa3e21753ab68239997dab0c
Our current choice for a Carousel-like widget is the Scroll View oriented in a horizontal mode, but that doesn't give us the milky smooth locking of a carousel.
Hopefully, after i'm done w/ this VGM player app, I'll have the cycles (and skills) to build these types of custom components for submission into this repo.
The text was updated successfully, but these errors were encountered: