Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget suggestion : Carousel #132

Closed
jaygarcia opened this issue Mar 8, 2015 · 9 comments
Closed

Widget suggestion : Carousel #132

jaygarcia opened this issue Mar 8, 2015 · 9 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jaygarcia
Copy link
Contributor

Our current choice for a Carousel-like widget is the Scroll View oriented in a horizontal mode, but that doesn't give us the milky smooth locking of a carousel.

Hopefully, after i'm done w/ this VGM player app, I'll have the cycles (and skills) to build these types of custom components for submission into this repo.

@sahrens
Copy link
Contributor

sahrens commented Mar 8, 2015

What do you want different exactly? Did you set the pagination prop true?

On Mar 8, 2015, at 10:13 AM, Jay Garcia notifications@github.com wrote:

Our current choice for a Carousel-like widget is the Scroll View oriented in a horizontal mode, but that doesn't give us the milky smooth locking of a carousel.

Hopefully, after i'm done w/ this VGM player app, I'll have the cycles (and skills) to build these types of custom components for submission into this repo.


Reply to this email directly or view it on GitHub.

@jaygarcia
Copy link
Contributor Author

Maybe this is an opportunity to make this feature more developer-friendly? I had no idea that something called "pagination" would be used as a carousel. I'm used to pagination meaning "pages of data queried and viewed". :-\

I imagine there could be an extension to ScrollView called a Carousel that sets pagingEnabled to true by default and renders indicators.

Examples (Sencha Touch) -- Common UI pattern.
horiz-carousel
vert-carousel

@sahrens
Copy link
Contributor

sahrens commented Mar 9, 2015

That could be handy - a component could also do some processing of the raw onScroll data to provide onChangeCard. Want to send a PR?

On Mar 8, 2015, at 4:28 PM, Jay Garcia notifications@github.com wrote:

Maybe this is an opportunity to make this feature more developer-friendly? I had no idea that something called "pagination" would be used as a carousel. I'm used to pagination meaning "pages of data queried and viewed". :-\

I imagine there could be an extension to ScrollView called a Carousel that sets pagingEnabled to true by default and renders indicators.

Examples (Sencha Touch) -- Common UI pattern.


Reply to this email directly or view it on GitHub.

@nick
Copy link

nick commented Mar 18, 2015

I actually made a Carousel component in my fork here. Example usage here.

@ppong
Copy link

ppong commented Mar 27, 2015

@nick the Carousel sounds awesome. Unfortunately https://github.com/nick/react-native/blob/master/Examples/Weather/js/components/Carousel.js leads to a 404.

@nick
Copy link

nick commented Mar 27, 2015

@ppong oops - try now

@ppong
Copy link

ppong commented Mar 28, 2015

@nick thanks! it works now 👍

@nick
Copy link

nick commented Apr 3, 2015

I've now released this as an npm module at http://github.com/nick/react-native-carousel

@brentvatne
Copy link
Collaborator

@nick - nice one, thanks! 👍

facebook-github-bot pushed a commit that referenced this issue Jan 6, 2017
Summary:
Added baseline support (see #132)

You have the ability for a custom baseline function (```float(*YGBaselineFunc)(YGNodeRef node);```) to return whatever baseline you want.
Closes facebook/yoga#317

Reviewed By: splhack

Differential Revision: D4385061

Pulled By: emilsjolander

fbshipit-source-id: cb8a59a09237c840fa3e21753ab68239997dab0c
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants