Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tried to show an alert while not attached to an Activity #13439

Closed
fredsun opened this issue Apr 11, 2017 · 12 comments
Closed

Tried to show an alert while not attached to an Activity #13439

fredsun opened this issue Apr 11, 2017 · 12 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@fredsun
Copy link

fredsun commented Apr 11, 2017

  • android 7.0
  • react-native 0.43
  • when i use the 'alert' in an android app which integrated the react-native
    the code after:

	import React, {Component} from 'react';
	import {
	    AppRegistry,
	    StyleSheet,
	    Text,
	    View,
	    Navigator,
	    Button,
	    Alert,
	} from 'react-native';
	
	
	class HelloWorld extends React.Component {
	    show(){
	        Alert.alert(
	            'Alert Title',
	            'alertMessage',
	        )
	    }
	    render() {
	        return (
	            < View
	                style={styles.container
	                }>
	                <Text
	                    style={styles.hello
	                    }>
	                    Hello, World </ Text >
	                <Button title="a"
	                        onPress={this.show.bind(this)
	                        }/>
	            </ View >
	        )
	    }
	}
	
	var styles = StyleSheet.create({
	    container: {
	        flex: 1,
	        justifyContent: 'center',
	    },
	    hello: {
	        fontSize: 20,
	        textAlign: 'center',
	        margin: 10,
	    },
	});
	
	AppRegistry.registerComponent('a', () => HelloWorld);

it give me the warning like this and no dialog show

@vonovak
Copy link
Collaborator

vonovak commented Apr 11, 2017

try to show the alert after a timeout, eg 100ms

@fredsun
Copy link
Author

fredsun commented Apr 12, 2017

no.
there is nothing wrong with the timeout.
i find it that just because i integrated the react-native with my Android App,
if i run it as a independent react-native project, that's ok
but if i integrate it into my android app, there's this warning and there's no dialog come out

@esilverberg
Copy link

esilverberg commented Apr 15, 2017

I also experience the same behavior -- "run it as a independent react-native project, that's ok", "if i integrate it into my android app, there's this warning and there's no dialog come out"

Running RN 0.43.0

@ymmn
Copy link

ymmn commented Apr 21, 2017

I also ran into this when I followed the integration with existing apps tutorial.

But it's not an issue when you make your application implement ReactApplication and your activity inherit from ReactActivity

@fredsun
Copy link
Author

fredsun commented Apr 27, 2017

@ymmn it seems that there's no ReactApplication in RN 0.42.0

@ymmn
Copy link

ymmn commented Apr 27, 2017

@sunxlfree hmm, seems like ReactApplication hasnt been touched in a year. it should be there

@saghul
Copy link
Contributor

saghul commented May 23, 2017

I had the same problem, and I solved it by hooking my custom activity's (the one which renders the ReactNativeRootView) lifecycle methods to the ReactNativeInstanceManager as the docs describe: http://facebook.github.io/react-native/releases/0.42/docs/integration-with-existing-apps.html#add-native-code

Specifically I added onPause, onResume, onDestroy and onBackPressed (though you don't need the last one). By reading the code here you'll see that the current activity is saved with those.

I hope that helps. Cheers!

@hramos hramos added Icebox and removed Icebox labels Jul 25, 2017
@pull-bot
Copy link

pull-bot commented Oct 9, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Oct 9, 2017
@hramos hramos closed this as completed Oct 9, 2017
@froimsonm
Copy link

Facing same issue.
I followed the integration with existing apps tutorial.

RN version 0.48.3

@MephistoDemon
Copy link

Facing same issue.
I followed the integration with existing apps tutorial.

RN version 0.48.0

@marcmo
Copy link

marcmo commented Jun 11, 2018

why is this closed? it still is very much an issue!
for me I see this a lot, running with
RN version 0.55.13

@MarkOSullivan94
Copy link

For anyone who is experiencing this issue while using RN in a fragment, make sure you have defined the current activity for the ReactInstanceManager.

Example:

 mReactInstanceManager = ReactInstanceManager.builder()
                .setApplication(getActivity().getApplication())
                .setCurrentActivity(getActivity())
                .setBundleAssetName("index.android.bundle")
                .setJSMainModulePath("index")
                .addPackage(new MainReactPackage())
                .setUseDeveloperSupport(BuildConfig.DEBUG)
                .setInitialLifecycleState(LifecycleState.RESUMED)
                .build();

@facebook facebook locked as resolved and limited conversation to collaborators Oct 9, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 9, 2018
RoJoHub added a commit to RoJoHub/react-native that referenced this issue Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests