Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[43+] Navigator docs are mentioned, but the links are broken: #13620

Closed
jaygarcia opened this issue Apr 21, 2017 · 2 comments
Closed

[43+] Navigator docs are mentioned, but the links are broken: #13620

jaygarcia opened this issue Apr 21, 2017 · 2 comments
Assignees
@hramos
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jaygarcia
Copy link
Contributor

See: https://facebook.github.io/react-native/releases/next/docs/navigation.html

Find
Check out the Navigator API reference for specific examples that cover each of these scenarios.

The Navigator API reference is linked to https://facebook.github.io/react-native/releases/next/docs/navigator.html

That URL is not valid. :(

Navigator is still useful as react-navigation still has problems and is no where as near as flexible today as Navigator is. :(
@jaygarcia
Copy link
Contributor Author

jaygarcia commented Apr 21, 2017 •
edited
Loading

FWIW, Seems like 0.42 docs are fine. https://facebook.github.io/react-native/releases/0.42/docs/navigator.html

¯\(ツ)/¯

@hramos hramos self-assigned this Apr 24, 2017
@hramos
Copy link
Contributor

hramos commented Apr 26, 2017

Navigator is deprecated and has been removed from the core react-native package. It can now be installed and imported from react-native-deprecated-custom-components instead of react-native.

These remaining references are in error and I'll remove them shortly. Docs for the now deprecated Navigator can always be accessed by loading docs for older releases prior to its deprecation.

@hramos hramos mentioned this issue Apr 26, 2017
Closed
thotegowda pushed a commit to thotegowda/react-native that referenced this issue May 7, 2017
@hramos @thotegowda
Remove reference to deprecated Navigator.js
e399e06 
Summary:
Navigator.html no longer exists. Fixes facebook#13620.
Closes facebook#13672

Differential Revision: D4960726

Pulled By: hramos

fbshipit-source-id: 00beb2f11ab347227e1a703b8b1f4cea2701f838
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hramos hramos

Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hramos @jaygarcia @react-native-bot